Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crash when all entries are deleted from a group #4156

Merged
merged 1 commit into from Jan 16, 2020

Conversation

@droidmonkey
Copy link
Member

droidmonkey commented Jan 11, 2020

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Description and Context

  • Fix #4093 - The first entry in the list is selected after deleting an entry
  • Prevents crashes due to dangling pointers held by the Entry Preview Widget when entries were deleted.

Testing strategy

Tested numerous permutations of entries and deleting them. Added two fail checks (one in EntryPreviewWidget, one in DatabaseWidget).

Checklist:

  • I have read the CONTRIBUTING document. [REQUIRED]
  • My code follows the code style of this project. [REQUIRED]
  • All new and existing tests passed. [REQUIRED]
  • I have compiled and verified my code with -DWITH_ASAN=ON. [REQUIRED]
  • My change requires a change to the documentation, and I have updated it accordingly.
  • I have added tests to cover my changes.
@droidmonkey droidmonkey added this to the v2.5.3 milestone Jan 11, 2020
@droidmonkey droidmonkey requested a review from phoerious Jan 11, 2020
@phoerious

This comment has been minimized.

Copy link
Member

phoerious commented Jan 11, 2020

Is it possible to add these tests as actual tests?

@droidmonkey

This comment has been minimized.

Copy link
Member Author

droidmonkey commented Jan 11, 2020

Yea I can add a gui test that checks the behavior

* Fix #4093 - The first entry in the list is selected after deleting an entry
* Prevents crashes due to dangling pointers held by the Entry Preview Widget when entries were deleted.
* Improve GUI tests to ensure this new behavior occurs.
@droidmonkey droidmonkey force-pushed the hotfix/empty-group-crash branch from f2fb165 to f8c1d4b Jan 13, 2020
@droidmonkey

This comment has been minimized.

Copy link
Member Author

droidmonkey commented Jan 13, 2020

GUI tests updated!

@droidmonkey droidmonkey merged commit 0d3eb04 into release/2.5.3 Jan 16, 2020
4 checks passed
4 checks passed
Code Format (KeepassXC) TeamCity build finished
Details
MacOS (KeepassXC) TeamCity build finished
Details
Ubuntu Linux (KeepassXC) TeamCity build finished
Details
Windows 10 (KeepassXC) TeamCity build finished
Details
@droidmonkey droidmonkey deleted the hotfix/empty-group-crash branch Jan 16, 2020
phoerious added a commit that referenced this pull request Jan 19, 2020
Fixed

- Fix a possible database lockout when removing a YubiKey from a KDBX 3.1 database [#4147]
- Fix crash if Auto-Type is performed on a new entry [#4150]
- Fix crash when all entries are deleted from a group [#4156]
- Improve the reliability of clipboard clearing on Gnome [#4165]
- Do not check cmd:// URLs for valid URL syntax anymore [#4172]
- Prevent unnecessary merges for databases on network shares [#4153]
- Browser: Prevent native messaging proxy from blocking application shutdown [#4155]
- Browser: Improve website URL matching [#4134, #4177]

Added

- Browser: Enable support for Chromium-based Edge Browser [#3359]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.