Implement KDBX 4.1 #7114
Merged
Implement KDBX 4.1 #7114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just thinking we need to do this! We'll do this as a merge commit when the time comes. |
|
Can't do 2.7 without. |
phoerious
force-pushed
the
feature/kdbx4.1
branch
from
49920d8
to
da2cd06
Compare
|
@phoerious please keep in mind that we will remove |
|
We should merge that first |
phoerious
force-pushed
the
feature/kdbx4.1
branch
2 times, most recently
from
7dd943f
to
81a20fd
Compare
Codecov Report
@@ Coverage Diff @@
## develop #7114 +/- ##
===========================================
+ Coverage 64.13% 64.21% +0.08%
===========================================
Files 333 334 +1
Lines 42015 42221 +206
===========================================
+ Hits 26944 27109 +165
- Misses 15071 15112 +41
Continue to review full report at Codecov.
|
phoerious
force-pushed
the
feature/kdbx4.1
branch
from
81a20fd
to
054d7ce
Compare
phoerious
force-pushed
the
feature/kdbx4.1
branch
2 times, most recently
from
625315c
to
9ee8b55
Compare
droidmonkey
requested changes
Nov 19, 2021
We keep the old merging behaviour for now, since deleting a CustomData entry does not create DeletedObject.
phoerious
force-pushed
the
feature/kdbx4.1
branch
3 times, most recently
from
02cde7a
to
aa82c18
Compare
phoerious
force-pushed
the
feature/kdbx4.1
branch
3 times, most recently
from
4dddda7
to
cf716f8
Compare
droidmonkey
requested changes
Nov 20, 2021
Shows a warning when trying to open with a newer minor version than what is currently supported. We always try to save with the lowest KDBX version possible for maximum compatibility.
phoerious
force-pushed
the
feature/kdbx4.1
branch
from
cf716f8
to
c2d4dba
Compare
droidmonkey
approved these changes
Nov 22, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Implements KDBX 4.1 as described in https://keepass.info/help/kb/kdbx_4.1.html and adds test cases.
Progress:
Individual commits pass tests and don't need to be squashed.
Type of change