fix backwards logic in canDropPrivs()#282
Closed
mrnerdhair wants to merge 3 commits intomasterfrom
Closed
Conversation
markrypto
previously approved these changes
Jul 12, 2021
Collaborator
Author
|
@markrypto (please make sure to reset master to 04ef714 instead of adding a merge commit, since the v7.1.6 binary has that commit hash embedded) |
mvpratt
previously approved these changes
Jul 12, 2021
mrnerdhair
force-pushed
the
fix-logic-bug
branch
from
04ef714 to
50a9656
Compare
mrnerdhair
dismissed
markrypto’s stale review
added fix for #283, need re-review
mrnerdhair
dismissed
BitHighlander’s stale review
added fix for #283, need re-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0527170 contained an extra
!which, when using bootloader v2.0.0, breaks unsigned firmware and prevents signed builds from dropping their privs.This error made it past our testing regime because it didn't trigger on our normal testing devices; props to @greatwolf for bringing it to our attention as #281.