Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies part 1 #314

Merged
merged 3 commits into from Oct 1, 2021
Merged

Update dependencies part 1 #314

merged 3 commits into from Oct 1, 2021

Conversation

bpinto
Copy link
Contributor

@bpinto bpinto commented Sep 1, 2021

  • Updates package-lock.json file to version 2 - requires npm 7+.
  • Updates all packages using npm update.

@bpinto bpinto mentioned this pull request Sep 1, 2021
Merged
@bpinto bpinto mentioned this pull request Sep 9, 2021
Merged
@bpinto
lockfileVersion@2
7379a56 
`npm install` using npm 7+.
@bpinto
npm update
2aa0061
@mAAdhaTTah
Copy link
Contributor

If we need npm 7+, I think we need to upgrade npm in CI as well.

@bpinto
Copy link
Contributor Author

bpinto commented Sep 30, 2021

I'm not sure how the npm requirement works, I mean, node 12 doesn't get npm 7 by default but still npm ci was passing.

I have pushed an update to the CI workflow to install node@7 on all node versions.

@mAAdhaTTah mAAdhaTTah merged commit 5d2d9d5 into kefirjs:master Oct 1, 2021
@mAAdhaTTah
Copy link
Contributor

mAAdhaTTah commented Oct 1, 2021 •
edited

Yeah, I think the v2 of the lockfile is basically backwards compatible, so it's not a huge deal. Thank you for the updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mAAdhaTTah mAAdhaTTah mAAdhaTTah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bpinto @mAAdhaTTah