fixes #134: Display license badge even when there is no license url

[anku255]

When there is a license name but no license URL, we will show the license badge with href=#.

Example Image:

I ran the tests and all tests are passing.

If it is not the desired fix, please let me know and I will update my PR accordingly.

Thank you.

[codecov]

Codecov Report

Merging #139 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #139   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          24     23    -1     
  Lines         197    196    -1     
  Branches       21     21           
=====================================
- Hits          197    196    -1

Impacted Files	Coverage Δ
src/questions/project-demo-url.js

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d67b012...3dbf75c. Read the comment docs.

[kefranabg]

I think some refacto could be done with the license badges. For example for the no-html template, we could have something like:

<% if (licenseName) { -%>
[![License: <%= licenseName %>](https://img.shields.io/<% if (isGithubRepos) { -%>
github/license/<%= authorGithubUsername %>/<%= projectName %><% } else { -%>
badge/License-<%= licenseName %>-yellow.svg
<% } -%>
)](<% if (licenseUrl) { -%>
<%= licenseUrl %><% } else { -%>
#<% } -%>
)
<% } -%> 

Not that easy to understand but it remove duplicated code

[anku255]

Hi @kefranabg! Thanks for reviewing my code.

I have used the ternary operator to remove the duplicated code. It looked more readable to me than using if statements. If you don't feel the same way then I will use if statements instead.

[kefranabg]

@anku255 Way better you're right

[kefranabg]

Thanks for you work!

[kefranabg]

@all-contributors please add anku255 for code

[allcontributors]

@kefranabg

I've put up a pull request to add @anku255! 🎉