Don't assume nest contains a bit field #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Just want to follow up on this. Is there anything additional I can do for this PR? |
Owner
|
Sorry for the delay, this looks good. As you might have guessed, the bit parsers haven't been extensively used. Your debugging is really helpful! |
Contributor
Author
|
Thanks for all of your work on this library! It's been very helpful. I saw you've been working on some other housekeeping changes. Are you planning to release a new version of the library on NPM soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a fix for Issue #240. Previously a bit field followed by a nest would generate parser code in the wrong order. This PR adds additional logic to determine if the next field is a bit field or not. If the next parser is a nest, we now examine the first field in it. I'll try to add some additional test cases but just want to get this open so the review process can start. Currently all test cases pass.