お知らせ編集の[参加するか尋ねる]の状態を保存されている値で表示する（指摘事項対応） #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-oginogin
changed the title
| password 'secret1234' | ||
| password_confirmation { password } | ||
|
|
||
| trait :admin_user do |
There was a problem hiding this comment.
特に命名規則があるわけじゃないですけど、"as_admin"とかがいいかなーと。 (create :user, :as_adminだと英語っぽく読める)
他にも"with_xxx"みたいなパターンがよく使われるかも。
t-oginogin
changed the title
t-oginogin
changed the title
|
@JunichiIto 修正しました。時間のあるときにレビューをお願いします。
|
| trait :as_admin do | ||
| email 'admin@example.com' | ||
| password '00000000' | ||
| password_confirmation { password } |
There was a problem hiding this comment.
password をtraitごとに変える必要はあるのかな？
別に全部同じでもいいのでは？
There was a problem hiding this comment.
確かにそうですね。修正しておきます。
|
@t-oginogin 2点コメントしました。それ以外は大丈夫そうです。 |
|
@JunichiIto 修正しました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JunichiIto @maskoba さんのプルリクの指摘事項に対応しました。
時間ある時にレビューをお願いします。