Fixed loss of timeZone when the parameters are passed as an object. #37

Merged
merged 1 commit into from Jun 8, 2012

Conversation

Projects
None yet
3 participants

baryshev commented Jun 7, 2012

No description provided.

This pull request passes (merged 912fb5e into bec0721).

Collaborator

ncb000gt commented Jun 8, 2012

I'm not sure I follow. You've moved one line after the other. How was the timezone lost when passed as an object?

baryshev commented Jun 8, 2012

Object passed to function in the cronTime variable. In the previous version cronTime variable extracts from object (cronTime) before timeZone variable and redefine it. In next line cronTime.timeZone always undefined because cronTime already string, not object with parameters.

@ncb000gt ncb000gt added a commit that referenced this pull request Jun 8, 2012

@ncb000gt ncb000gt Merge pull request #37 from baryshev/patch-1
Fixed loss of timeZone when the parameters are passed as an object.
b74a8c0

@ncb000gt ncb000gt merged commit b74a8c0 into kelektiv:master Jun 8, 2012

Collaborator

ncb000gt commented Jun 8, 2012

You should have heard me when I went back to look at the code...I think I sounded like a wounded walrus...or at least what I'd imagine a wounded walrus to sound like.

That was a stupid mistake. Thanks for catching this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment