Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
GH-36 Changes for cron syntax compat (dayOfWeek 0-6 and no-seconds syntax support) #41
Here are the changes for cron syntax compatibility. The parsing scenarios are really a matter of preference. I'm actually not certain what Unix cron does.
Personally as a consumer I'd prefer it throw for <5 to avoid any confusion on the above.
referenced this pull request
Aug 7, 2012
Awesome, thanks! Yeah would be good to update the version or let people know, not sure the proper node etiquette. Depending on their npm usage of node-cron is seems like they might get in trouble. For example, we have some services that do an npm install/update during each service deploy.
I think you'll find that it will usually be fine, but there will be that one case where something changes in a very unexpected way and poof, no more DB or something like that. :) Only takes one of those to happen before you start getting REAL specific- not that I'm speaking from experience or anything...I mean, who loses data...really...cough
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Here's a great article for package dependencies standards. http://blog.nodejitsu.com/package-dependencies-done-right.
So I use entries like 0.2.x (major.minor.patch), with the (hopefully true) assumption that patches are non-breaking and good to have, but upgrade a major or minor version should be investigated/tested before integration.