Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using an enterprise artifactory. #647

Merged
merged 1 commit into from Jun 1, 2020
Merged

Conversation

@ilatypov
Copy link
Contributor

@ilatypov ilatypov commented Aug 31, 2018

Revert to using a deep remote path so that the local artifactory can host gyp binaries of different packages.

@ilatypov
Copy link
Contributor Author

@ilatypov ilatypov commented Aug 31, 2018

The small change in node-pre-gyp will allow to use a single .npmrc variable to host binary requisites for many packages in one enterprise artifactory.

mapbox/node-pre-gyp#416

Loading

@recrsn
Copy link
Collaborator

@recrsn recrsn commented Sep 14, 2018

Reverting to a deep remote path will block the usage of node-pre-gyp-github. We use it to automatically deploy binaries from CI

Loading

@ilatypov
Copy link
Contributor Author

@ilatypov ilatypov commented Sep 14, 2018

By "deep" remote paths I meant not ignoring any part of remote_path but allowing host to have its own root path. A change I suggested in node-pre-gyp will allow that and will agree with existing remote_path values not starting with a slash.

The suggested change in node-pre-gyp will change the install behaviour of a supposedly small number of consumers of existing packages that fall into the following trap,

  • their remote_path value starts with a slash and
  • their host override via PACKAGE_binary_host_mirror has a non-empty root path.

The install behaviour of these packages will change from erasing the root path in PACKAGE_binary_host_mirror to honouring it.

mapbox/node-pre-gyp#415

mapbox/node-pre-gyp@dffeb29

Existing versions of bcrypt will not change their install behaviour unless their consumer defines a bcrypt_binary_host_mirror with a non-empty root path and happens to use v2.0.1 of bcrypt whose use of the current node-pre-gyp erases the root path at install time.

https://github.com/kelektiv/node.bcrypt.js/blob/v2.0.1/package.json

Loading

@recrsn
Copy link
Collaborator

@recrsn recrsn commented Oct 22, 2018

@ilatypov I'm considering using https://github.com/prebuild/prebuild. Will it be able to solve your use case? See the prebuild-install module. It contains configuration switches which is similar to your case.

Loading

Revert to using a deep path so that the local artifactory can host gyp binaries of different packages.

A small change in node-pre-gyp will allow to use a single .npmrc variable to host binary requisites for many packages in one enterprise artifactory.

mapbox/node-pre-gyp#416
@recrsn recrsn merged commit cf4efd9 into kelektiv:master Jun 1, 2020
4 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants