Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set res to 0 only if unit is "W" #94

Merged
merged 3 commits into from
Dec 22, 2021
Merged

Set res to 0 only if unit is "W" #94

merged 3 commits into from
Dec 22, 2021

Conversation

rklomp
Copy link
Collaborator

@rklomp rklomp commented Dec 19, 2021

Fixes #93 and home-assistant/core#61838

As setting everything back to 0 can cause issues with HA Statistics, I propose to set it only to 0 for sensors with unit "W".

@codecov
Copy link

codecov bot commented Dec 19, 2021

Codecov Report

Merging #94 (eda593b) into master (b060f38) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #94   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          419       419           
=========================================
  Hits           419       419           
Impacted Files Coverage Δ
pysma/sensor.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b060f38...eda593b. Read the comment docs.

@rklomp rklomp merged commit ed80032 into kellerza:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

total_yield returns 0 during the night
1 participant