Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add support for Google Maps API For Work params #45
The Maps API can be used with a Google business account but this require a different authentication method than a simple API key and request URL signing.
This Pull Request adds support for this auth method based on the documentation provided here: https://developers.google.com/maps/documentation/business/webservices/auth
I reused the same
Heya! Thanks for taking the time to make Pull Request
This is definitely a change I can see benefitting a lot of people, so thanks for doing it! This is a relatively big change, and as such, I had a few thoughts before proceeding. I left a few comments inline, let me know what you think!
Making geocoder implementations has been the biggest source of PRs for this lib, and admittedly, it's the place that needs the most love. A few of these were made in haste without considering how other people might use them, or using different auth schemas. As such, I want to use this opportunity to clean up things a bit so we can have the cleanest implementation as possible!
Hello, I refactored the code to add your proposed
@skateinmars heya! Sorry for the delay in responding, it's been a busy week or so for me.
I'm still making a decision on how to handle the backwards compatible changes. I started writing up a set of features I'd like to see in a v1.0.0 release of
I think your work might be a good starting point to create a
That being said, I might hold off on introducing your featureset into
How do you feel about that?