Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use native uuid_create on BSD systems #2

Merged
merged 6 commits into from Aug 24, 2012
Merged

use native uuid_create on BSD systems #2

merged 6 commits into from Aug 24, 2012

Conversation

@joecaswell
Copy link
Contributor

@joecaswell joecaswell commented Aug 24, 2012

When running moss on bsd there is a namespace conflict between ossp-uuid and uuid provided with the os. The linking is done dynamically when run under erlang, resulting in segfault if the native uuid_create is used instead of the ossp variety.
The native function returns data in the same format and so can be used as a drop in replacement.

{"^bsd","DRV_CFLAGS", "$DRV_CFLAGS -Werror -I c_src/uuid-1,6,2"},
{"^bsd","DRV_LDFLAGS", "$DRV_LDFLAGS c_src/uuid-1,6,2/,libs/libuuid,a"},
%% BSD provides uuid_create natively
{"bsd","DRV_CFLAGS", "$DRV_CFLAGS -Werror"},

This comment has been minimized.

@kellymclaughlin

kellymclaughlin Aug 24, 2012
Owner

The comma at the end of this line and the following line give me a synax error when trying to run make.

typos in config script
]},
],
case rebar_utils:is_arch("bsd") of
match ->

This comment has been minimized.

@kellymclaughlin

kellymclaughlin Aug 24, 2012
Owner

rebar_utils:is_arch/1 will return true or false instead of match or nomatch.

@kellymclaughlin
Copy link
Owner

@kellymclaughlin kellymclaughlin commented Aug 24, 2012

The dynamic rebar configs will require the repo version of rebar to be updated. Could you add that also?

kellymclaughlin added a commit that referenced this pull request Aug 24, 2012
Use native uuid_create on BSD systems
@kellymclaughlin kellymclaughlin merged commit b3c5c2a into kellymclaughlin:master Aug 24, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants