Skip to content
Browse files

- adding code-quality plugin

  • Loading branch information...
1 parent 7bdf7e1 commit 3ab96c1db47c41acca00aadd7208d2f70fa44390 @kellyrob99 committed Feb 12, 2011
View
1 build.gradle
@@ -2,6 +2,7 @@ apply plugin: 'groovy'
apply plugin: 'idea'
apply plugin: 'project-report'
apply plugin: 'maven'
+apply plugin: 'code-quality'
buildscript {
repositories {
View
99 config/checkstyle/checkstyle.xml
@@ -0,0 +1,99 @@
+<!--
+ ~ Copyright 2010 the original author or authors.
+ ~
+ ~ Licensed under the Apache License, Version 2.0 (the "License");
+ ~ you may not use this file except in compliance with the License.
+ ~ You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+<!DOCTYPE module PUBLIC
+ "-//Puppy Crawl//DTD Check Configuration 1.2//EN"
+ "http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
+<module name="Checker">
+ <module name="TreeWalker">
+ <!-- Blocks -->
+ <module name="EmptyBlock">
+ <property name="option" value="stmt"/>
+ <property name="tokens" value="LITERAL_DO,LITERAL_ELSE,LITERAL_FINALLY,LITERAL_IF,LITERAL_FOR,LITERAL_TRY,LITERAL_WHILE,INSTANCE_INIT,STATIC_INIT"/>
+ </module>
+ <module name="EmptyBlock">
+ <property name="option" value="text"/>
+ <property name="tokens" value="LITERAL_CATCH"/>
+ </module>
+ <module name="AvoidNestedBlocks"/>
+
+ <!-- Braces -->
+ <module name="LeftCurly"/>
+ <module name="RightCurly"/>
+ <module name="NeedBraces"/>
+
+ <!-- Whitespace -->
+ <module name="GenericWhitespace"/>
+ <module name="EmptyForInitializerPad"/>
+ <module name="EmptyForIteratorPad"/>
+ <module name="MethodParamPad"/>
+ <module name="NoWhitespaceBefore"/>
+ <module name="NoWhitespaceAfter"/>
+ <module name="OperatorWrap"/>
+ <module name="ParenPad"/>
+ <module name="TypecastParenPad"/>
+ <module name="WhitespaceAfter">
+ <property name="tokens" value="COMMA, SEMI"/>
+ </module>
+ <!--<module name="WhitespaceAround">-->
+ <!-- everything except { and } -->
+ <!--<property name="tokens" value="ASSIGN, BAND, BAND_ASSIGN, BOR, BOR_ASSIGN, BSR, BSR_ASSIGN, BXOR, BXOR_ASSIGN, COLON, DIV, DIV_ASSIGN, EQUAL, GE, GT, LAND, LE, LITERAL_ASSERT, LITERAL_CATCH, LITERAL_DO, LITERAL_ELSE, LITERAL_FINALLY, LITERAL_FOR, LITERAL_IF, LITERAL_RETURN, LITERAL_SYNCHRONIZED, LITERAL_TRY, LITERAL_WHILE, LOR, LT, MINUS, MINUS_ASSIGN, MOD, MOD_ASSIGN, NOT_EQUAL, PLUS, PLUS_ASSIGN, QUESTION, SL, SLIST, SL_ASSIGN, SR, SR_ASSIGN, STAR, STAR_ASSIGN, TYPE_EXTENSION_AND"/>-->
+ <!--</module>-->
+
+ <!-- Coding -->
+ <module name="CovariantEquals"/>
+ <module name="DefaultComesLast"/>
+ <module name="EmptyStatement"/>
+ <module name="EqualsHashCode"/>
+ <module name="ExplicitInitialization"/>
+ <module name="MultipleVariableDeclarations"/>
+ <module name="NoClone"/>
+ <module name="NoFinalizer"/>
+ <module name="RedundantThrows">
+ <property name="allowUnchecked" value="true"/>
+ </module>
+ <module name="SimplifyBooleanExpression"/>
+ <module name="SimplifyBooleanReturn"/>
+ <module name="StringLiteralEquality"/>
+ <module name="UnnecessaryParentheses"/>
+
+ <!-- Design -->
+ <module name="InterfaceIsType"/>
+
+ <!-- Imports -->
+ <module name="RedundantImport"/>
+ <module name="UnusedImports"/>
+
+ <!-- Naming -->
+ <module name="ClassTypeParameterName"/>
+ <module name="ConstantName"/>
+ <module name="LocalFinalVariableName"/>
+ <module name="LocalVariableName"/>
+ <module name="MemberName"/>
+ <module name="MethodName"/>
+ <module name="MethodTypeParameterName"/>
+ <module name="PackageName">
+ <property name="format" value="^[a-z]+(\.[a-z][a-z0-9]*)*$"/>
+ </module>
+ <module name="ParameterName"/>
+ <module name="StaticVariableName"/>
+ <module name="TypeName"/>
+
+ </module>
+ <module name="RegexpHeader">
+ <property name="headerFile" value="${checkstyleConfigDir}/required-header.txt"/>
+ </module>
+ <module name="FileTabCharacter"/>
+</module>
View
41 config/codenarc/codenarc.xml
@@ -0,0 +1,41 @@
+<!--
+ ~ Copyright 2010 the original author or authors.
+ ~
+ ~ Licensed under the Apache License, Version 2.0 (the "License");
+ ~ you may not use this file except in compliance with the License.
+ ~ You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+<ruleset xmlns="http://codenarc.org/ruleset/1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://codenarc.org/ruleset/1.0 http://codenarc.org/ruleset-schema.xsd"
+ xsi:noNamespaceSchemaLocation="http://codenarc.org/ruleset-schema.xsd">
+ <ruleset-ref path='rulesets/basic.xml'>
+ <!--<exclude name='ExplicitHashSetInstantiation'/>-->
+ <!--<exclude name='ExplicitCallToAndMethod'/>-->
+ <!--<exclude name='ExplicitCallToOrMethod'/>-->
+ </ruleset-ref>
+ <ruleset-ref path='rulesets/braces.xml'/>
+ <ruleset-ref path='rulesets/imports.xml'/>
+ <ruleset-ref path='rulesets/naming.xml'>
+ <rule-config name='ClassName'>
+ <property name='regex' value='^[A-Z][a-zA-Z0-9]*$'/>
+ </rule-config>
+ <rule-config name='FieldName'>
+ <property name='finalRegex' value='^[a-z][a-zA-Z0-9]*$'/>
+ <property name='staticFinalRegex' value='^[A-Z][A-Z_0-9]*$'/>
+ </rule-config>
+ <rule-config name='MethodName'>
+ <property name='regex' value='^[a-z][a-zA-Z0-9_]*$'/>
+ </rule-config>
+ <rule-config name='VariableName'>
+ <property name='finalRegex' value='^[a-z][a-zA-Z0-9]*$'/>
+ </rule-config>
+ </ruleset-ref>
+</ruleset>
View
1 src/test/groovy/org/kar/hudson/api/HudsonControlApiTest.groovy
@@ -5,6 +5,7 @@ import spock.lang.Specification
/**
* @author Kelly Robinson
*/
+@SuppressWarnings('MethodName')
class HudsonControlApiTest extends Specification
{
def rootUrl = 'http://localhost:8080/'
View
1 src/test/groovy/org/kar/hudson/api/JSONApiTest.groovy
@@ -8,6 +8,7 @@ import static java.net.HttpURLConnection.*
*
* @author Kelly Robinson
*/
+@SuppressWarnings('MethodName')
class JSONApiTest extends Specification
{
def rootUrl = 'http://localhost:8080/'
View
1 src/test/groovy/org/kar/hudson/api/UDPApiTest.groovy
@@ -8,6 +8,7 @@ import spock.lang.Unroll
*
* @author Kelly Robinson
*/
+@SuppressWarnings('MethodName')
class UDPApiTest extends Specification
{
final static UDP_RESPONSE_PATTERN = '<hudson><version>.*</version><url>http://localhost:8080/</url><slave-port>.*</slave-port></hudson>'
View
1 src/test/groovy/org/kar/hudson/api/cli/HudsonCliApiTest.groovy
@@ -5,6 +5,7 @@ import spock.lang.Specification
/**
* @author Kelly Robinson
*/
+@SuppressWarnings('MethodName')
class HudsonCliApiTest extends Specification
{
def rootUrl = 'http://localhost:8080/'

0 comments on commit 3ab96c1

Please sign in to comment.
Something went wrong with that request. Please try again.