New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs lost if LogEntries is unreachable. #2

Open
markstos opened this Issue May 22, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@markstos

markstos commented May 22, 2015

If there's a networking problem accessing LogEntries, the error will be logged to console.error(), but the log entry itself will discarded.

Other solutions I've seen involve pushing log entries on an in-memory queue, and flushing the queue when the connection is up again. It's important to have some upper-limit on the queue size in that design so memory doesn't end up exhausted from queue size growth.

@markstos

This comment has been minimized.

Show comment
Hide comment
@markstos

markstos May 22, 2015

If you wanted to depend on a LogEntries client instead of connecting directly, that project is working on exactly that kind of solution.

markstos commented May 22, 2015

If you wanted to depend on a LogEntries client instead of connecting directly, that project is working on exactly that kind of solution.

@kelonye

This comment has been minimized.

Show comment
Hide comment
@kelonye

kelonye May 22, 2015

Owner

@markstos thanks for checking out the project!

I used this in a project where losing logs was okay .. however, a service like fluentd would be the way to go. Here's a plugin Woorank/fluent-plugin-logentries or with docker logs kiyoto/docker-fluentd/.

Owner

kelonye commented May 22, 2015

@markstos thanks for checking out the project!

I used this in a project where losing logs was okay .. however, a service like fluentd would be the way to go. Here's a plugin Woorank/fluent-plugin-logentries or with docker logs kiyoto/docker-fluentd/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment