Raise kelos-workers and kelos-pr-responder maxConcurrency to 8#1167
Merged
Conversation
Both spawners often queue more incoming events than they can run in parallel (3 and 2). Bump to 8 so more tasks can run concurrently.
github-actions
Bot
added
kind/cleanup
needs-triage
needs-priority
needs-actor
release-note-none
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bumps
maxConcurrencyonkelos-workers(3 → 8) andkelos-pr-responder(2 → 8) so more incoming events can run in parallel.Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
Related to #1163, which bumps the per-task
requests.memoryfor these same two spawners from 512Mi to 1Gi. With 8 concurrent tasks per spawner and 1 GiB requests each, peak memory commitment is ~16 GiB across the two spawners — comfortably within node capacity.Does this PR introduce a user-facing change?
Summary by cubic
Increase
maxConcurrencyto 8 forkelos-workers(3→8) andkelos-pr-responder(2→8) so more incoming events run in parallel. This reduces queueing and event latency, and pairs with #1163’s memory bump to remain within node capacity.Written for commit 01e06f9. Summary will update on new commits. Review in cubic