Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign team cards to display all at once. #chore : (remove carousel) #38

Closed
kelvinkamau opened this issue Feb 25, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@kelvinkamau
Copy link
Owner

commented Feb 25, 2019

No description provided.

@pbrahmbhatt3

This comment has been minimized.

Copy link

commented Apr 5, 2019

Hi,

I would like to work on it. Can you provide me some more information about this issue?

@kelvinkamau

This comment has been minimized.

Copy link
Owner Author

commented Apr 6, 2019

Hello @pbrahmbhatt3
Feel free to go for it

More info

Steps

  • Fork project
  • Clone to local machine
  • Make changes to section
    • Remove entire section
    • Replace it following the mockup below
  • Push code for review

Final UI should look exactly like this

teamdemo

@kelvinkamau kelvinkamau transferred this issue from kelvinkamau/Vibranium Apr 7, 2019

@pbrahmbhatt3

This comment has been minimized.

Copy link

commented Apr 12, 2019

@kelvinkamau I have solved this issue and created a pull request. Can you please have a look at it? Thank you

@stellakaniaru

This comment has been minimized.

Copy link
Collaborator

commented Apr 20, 2019

Hey @pbrahmbhatt3
The PR you submitted was dealing with issue #40. It has been reviewed.
This one looks at redesigning the team cards, as @kelvinkamau described above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.