From d4381365e49def6ecd8e73ebcfdf57f6f452baeb Mon Sep 17 00:00:00 2001 From: Felipe Philipp Date: Sun, 2 Jul 2017 11:26:18 +0200 Subject: [PATCH] Default engine is already set on Config#initialize (#51) There is no need to have set_default_engine or engine_set flag since the default is already set on the initialization --- src/kemal-session/base.cr | 5 ++--- src/kemal-session/config.cr | 15 ++------------- 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/src/kemal-session/base.cr b/src/kemal-session/base.cr index b61114b..c3e4a04 100644 --- a/src/kemal-session/base.cr +++ b/src/kemal-session/base.cr @@ -10,7 +10,6 @@ class Session @context : HTTP::Server::Context? def initialize(ctx : HTTP::Server::Context) - Session.config.set_default_engine unless Session.config.engine_set? id = ctx.request.cookies[Session.config.cookie_name]?.try &.value valid = false if id @@ -28,7 +27,7 @@ class Session end ctx.response.cookies << Session.create_cookie(id) - @id = id + @id = id @context = ctx end @@ -38,7 +37,7 @@ class Session # check on the session_id # def initialize(id : String) - @id = id + @id = id @context = nil end diff --git a/src/kemal-session/config.cr b/src/kemal-session/config.cr index 43a0b40..9ad3fe5 100644 --- a/src/kemal-session/config.cr +++ b/src/kemal-session/config.cr @@ -9,18 +9,11 @@ class Session @secret : String @secure : Bool @domain : String? - @path : String + @path : String property timeout, gc_interval, cookie_name, engine, secret, secure, domain, path - @engine_set = false - - def engine_set? - @engine_set - end - def engine=(e : Engine) @engine = e - @engine_set = true end def initialize @@ -31,11 +24,7 @@ class Session @secret = "" @secure = false @domain = nil - @path = "/" - end - - def set_default_engine - Session.config.engine = MemoryEngine.new + @path = "/" end end # Config