Skip to content
This repository

Logback Appender #33

Merged
merged 7 commits into from about 1 year ago

3 participants

cyril Kevin Wetzels Ken Cochrane
cyril

Add Sentry appender for Logback logger

Kevin Wetzels
Collaborator

LogbackMDC uses org.slf4j.MDC, but the slf4j dependency is scoped for testing only. I'm not familiar with Logback and its numerous modules, so I'm not going to make the call on slf4j's scope for the raven-logback module.

cyril

Thanks roam, you're right. I have changed the scope of slf4j dependency.

Kevin Wetzels roam merged commit 283402b into from January 23, 2013
Kevin Wetzels roam closed this January 23, 2013
Kevin Wetzels
Collaborator

Thanks for the contribution! I've changed a few things in the master branch:

  • Clean up of the included readme file
  • Removal of the unused encoder property in SentryAppender. Tests still work so I assume this really isn't necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
4  .travis.yml
... ...
@@ -0,0 +1,4 @@
  1
+language: java
  2
+jdk:
  3
+  - openjdk7
  4
+  - openjdk6
6  old/README.rst
Source Rendered
@@ -6,6 +6,12 @@ It is officially recognized as production-ready by Sentry: http://sentry.readthe
6 6
 
7 7
 The log4j appender is asyncronous by design so there is no need to put it in a AsyncAppender.
8 8
 
  9
+Current Status
  10
+--------------
  11
+.. image:: https://secure.travis-ci.org/kencochrane/raven-java.png
  12
+   :target: http://travis-ci.org/kencochrane/raven-java
  13
+
  14
+
9 15
 Installation
10 16
 ------------
11 17
 
9  raven-logback/pom.xml
@@ -39,11 +39,12 @@
39 39
         </dependency>
40 40
         
41 41
         <dependency>
42  
-			<groupId>org.slf4j</groupId>
43  
-			<artifactId>slf4j-api</artifactId>
44  
-			<version>1.7.2</version>
45  
-			<scope>test</scope>
  42
+            <groupId>org.slf4j</groupId>
  43
+			      <artifactId>slf4j-api</artifactId>
  44
+			      <version>1.7.2</version>
  45
+		    </dependency>
46 46
 		</dependency>
  47
+>>>>>>> 7b2ec58b05074fbb4d39a4888a93a8eb9b02d7d9
47 48
     </dependencies>
48 49
 
49 50
     <build>
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.