Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit fixes #15

Merged
merged 8 commits into from Jul 22, 2019

Conversation

@kendricktan
Copy link
Owner

commented Jul 22, 2019

Fixed issues relating to EthereumCommonwealth/Auditing#321

  1. Removed forceCloseRing()
  2. Refunds amount if deposit is not an exact value (but if it's >0.1 ETH, 0.1ETH will be donated to the relayer for its services)
  3. Fixed GAS compensation
  4. Added Zero address checking
  5. Removed unused variable blocksPassed

@kendricktan kendricktan merged commit 4166e54 into master Jul 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kendricktan kendricktan deleted the audit-fixes branch Jul 22, 2019

@adrianmcli

This comment has been minimized.

Copy link

commented Jul 22, 2019

Looking like it's in tip-top shape thanks to the friendly auditors!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.