New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:bug: fix path for secret #1

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@toshi0607

toshi0607 commented Sep 28, 2018

The code is different from hands-on material and fails when invoking an issue bot function.
https://github.com/kenfdev/workshop/blob/ja/translations/ja/lab10.md#issue-bot-function%E3%81%AE%E6%9B%B4%E6%96%B0

@kenfdev

This comment has been minimized.

Owner

kenfdev commented Oct 12, 2018

Thanks a lot @toshi0607 ! This repository is only meant to update the ja branch and the master branch is pretty much behind the original repository openfaas/workshop.

The openfaas/workshop repository already has your fix applied in this commit. Thank you very much for your contribution though

@kenfdev

This comment has been minimized.

Owner

kenfdev commented Oct 12, 2018

Closing this PR since it is already fixed in the upstream version.

@kenfdev kenfdev closed this Oct 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment