New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added OutputStream as svg sink #113

Merged
merged 4 commits into from Oct 14, 2018

Conversation

Projects
None yet
3 participants
@tr00per
Contributor

tr00per commented Oct 8, 2018

closes #112

QRCode.from("www.example.org").svg(outs);
byte[] data = outs.toByteArray();
assertThat(data).isNotEmpty();
assertThat(data.length).isGreaterThan(0);

This comment has been minimized.

@plewand

plewand Oct 10, 2018

Doesn't above condition isNotEmpty handle it?

This comment has been minimized.

@tr00per

tr00per Oct 10, 2018

Contributor

yeah, removed

@kenglxn

Great work! Thanks for this

@kenglxn kenglxn merged commit 1d84899 into kenglxn:master Oct 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment