Make compatible with Android platform by introducing Modules and fixing #16 #17

Merged
merged 15 commits into from May 23, 2014

Conversation

Projects
None yet
2 participants
@atomfrede
Contributor

atomfrede commented May 18, 2014

Modules in order to make it compatible with android platform. Fixing #16 as I've also got more information regarding the problem (see #16 for details).

@atomfrede

This comment has been minimized.

Show comment
Hide comment
@atomfrede

atomfrede May 18, 2014

Contributor

Maybe this helps to fix the travis build: http://rkistner.github.io/android/2013/02/05/android-builds-on-travis-ci/

I've never used travis at all...

Contributor

atomfrede commented May 18, 2014

Maybe this helps to fix the travis build: http://rkistner.github.io/android/2013/02/05/android-builds-on-travis-ci/

I've never used travis at all...

@kenglxn

This comment has been minimized.

Show comment
Hide comment
@kenglxn

kenglxn May 19, 2014

Owner

You may be able to add the needed configuration to the travis.yml file in your branch and mark the commit with this same issue. That should trigger a new build and hopefully get android running.

Otherwise I will hopefully have some time later this week to look at it.

Owner

kenglxn commented May 19, 2014

You may be able to add the needed configuration to the travis.yml file in your branch and mark the commit with this same issue. That should trigger a new build and hopefully get android running.

Otherwise I will hopefully have some time later this week to look at it.

@kenglxn

This comment has been minimized.

Show comment
Hide comment
@kenglxn

kenglxn May 19, 2014

Owner

btw I noticed the example project travis.yml looks a bit different from the blog post: https://github.com/embarkmobile/android-maven-example/blob/master/.travis.yml

Owner

kenglxn commented May 19, 2014

btw I noticed the example project travis.yml looks a bit different from the blog post: https://github.com/embarkmobile/android-maven-example/blob/master/.travis.yml

kenglxn added a commit that referenced this pull request May 23, 2014

@kenglxn kenglxn merged commit 827ec99 into kenglxn:master May 23, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@kenglxn

This comment has been minimized.

Show comment
Hide comment
@kenglxn

kenglxn May 23, 2014

Owner

I was just about to comment this issue, that I would be unable to look at it until next week, then I noticed you already fixed it. Seriously @atomfrede, you rock! :)

Thanks again for you great work 👍 👍

Owner

kenglxn commented May 23, 2014

I was just about to comment this issue, that I would be unable to look at it until next week, then I noticed you already fixed it. Seriously @atomfrede, you rock! :)

Thanks again for you great work 👍 👍

@kenglxn kenglxn changed the title from Modules and fixing #16 to Make compatible with Android platform by introducing Modules and fixing #16 Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment