-
Notifications
You must be signed in to change notification settings - Fork 61
Safely optional #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safely optional #73
Conversation
Tests? :-) I think safely doesn't have to be a dev dependency. |
I made it a development dependency so I could flesh out the tests :) Thanks for repremanding me 👍 Making commit comments where the tests should be |
@@ -105,7 +105,8 @@ def run_amqp! | |||
|
|||
cmdq = mq.queue( q, :durable => true ) | |||
cmdq.subscribe( :ack => true ) do |header, message| | |||
safely do | |||
|
|||
receiver = lambda do |header, message| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely needs specs as per @marcbowes instructions
At the moment, |
💯 times { 👍 } |
Based on some great feedback from @yorickpeterse, I'm making safely usage completely optional, albeit turned on by default.
The touchpoints were minor, so this should just work. Will play a bit a see before merging.
Feedback welcome.
/cc @marcbowes