Safely optional

[kennethkalmer]

Based on some great feedback from @YorickPeterse, I'm making safely usage completely optional, albeit turned on by default.

The touchpoints were minor, so this should just work. Will play a bit a see before merging.

Feedback welcome.

/cc @marcbowes

[marcbowes]

Tests? :-)

I think safely doesn't have to be a dev dependency.

[marcbowes]

Tests? :-)

I think safely doesn't have to be a dev dependency.

[kennethkalmer]

I made it a development dependency so I could flesh out the tests :)

Thanks for repremanding me 👍

Making commit comments where the tests should be

[kennethkalmer]

I made it a development dependency so I could flesh out the tests :)

Thanks for repremanding me 👍

Making commit comments where the tests should be

[kennethkalmer]

Definitely needs specs as per @marcbowes instructions

[marcbowes]

At the moment, Thread.abort_on_exception=true regardless of whether you have Safely or not. I think I agree with this, however this is done in the configure_safely method. I think you should rename this method to something else, e.g. configure_exception_handling, and then extract the safely stuff to configure_safely. You can then invoke that method if Safely is defined, ala configure_safely if safely_enabled?. The safely_enabled? method can be stubbed under test to return false for the case where you want to assert that it won't be configured when the gem isn't available. This is better than fiddling with constants at test time.

[marcbowes]

At the moment, Thread.abort_on_exception=true regardless of whether you have Safely or not. I think I agree with this, however this is done in the configure_safely method. I think you should rename this method to something else, e.g. configure_exception_handling, and then extract the safely stuff to configure_safely. You can then invoke that method if Safely is defined, ala configure_safely if safely_enabled?. The safely_enabled? method can be stubbed under test to return false for the case where you want to assert that it won't be configured when the gem isn't available. This is better than fiddling with constants at test time.

[kennethkalmer]

💯 times { 👍 }

[kennethkalmer]

💯 times { 👍 }