Use str instead of basestring #7

Merged
merged 1 commit into from May 8, 2012

Conversation

Projects
None yet
2 participants
Contributor

mahmoudhossam commented May 8, 2012

Created a new branch for Python 3, and made the only necessary change to make the module compatible with Python 3

I also used 2to3 to check if there's something else, it didn't find anything.

Disclaimer: I haven't tested anything, I'm assuming everything else works exactly the same.

Owner

kennethreitz commented May 8, 2012

🍰

@kennethreitz kennethreitz added a commit that referenced this pull request May 8, 2012

@kennethreitz kennethreitz Merge pull request #7 from mahmoudhossam/py3k
Use str instead of basestring
21e1b24

@kennethreitz kennethreitz merged commit 21e1b24 into kennethreitz:master May 8, 2012

Contributor

mahmoudhossam commented May 8, 2012

I think you should make a separate branch for python 3, the change I made won't work with Python 2.

I tested unicode strings with this function and it didn't work in python 2.

@kennethreitz kennethreitz added a commit that referenced this pull request May 8, 2012

@kennethreitz kennethreitz python 2 and 3 1c8eec3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment