Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

increased stdout size from 10KB to 10MB #45

Closed
wants to merge 1 commit into from

3 participants

@chassing

No description provided.

@akent

Any progress on getting this pull request merged? The obvious calculation error needs fixing.

@kennethreitz
Owner

This project is in a bit of a crisis state — it's really useful, and I use it on a daily basis. However, I wrote it in a few afternoons several years ago and haven't touched it since. In order to get the project into a stable state I'm closing all issues and pull requests

Don't take this as aggressive — it's just necessary for the project to make any progress any time soon (it's pretty clear the project is effectively unmaintained at the moment). Great things to come! Please watch the GitHub logs and feel free to re-open this discussion soon. I just need to really it into a good state first.

:sparkles: :heart: :sparkles:

@chassing chassing referenced this pull request
Closed

Truncation of stdout #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jun 29, 2012
  1. increase std_out size from 10KB to 10MB

    Christian Assing authored
This page is out of date. Refresh to see the latest.
Showing with 13 additions and 3 deletions.
  1. +3 −3 envoy/core.py
  2. +10 −0 test_envoy.py
View
6 envoy/core.py
@@ -73,13 +73,13 @@ def target():
if sys.version_info[0] >= 3:
self.out, self.err = self.process.communicate(
- input = bytes(self.data, "UTF-8") if self.data else None
+ input = bytes(self.data, "UTF-8") if self.data else None
)
else:
self.out, self.err = self.process.communicate(self.data)
except Exception as exc:
self.exc = exc
-
+
thread = threading.Thread(target=target)
thread.start()
@@ -203,7 +203,7 @@ def run(command, data=None, timeout=None, kill_timeout=None, env=None, cwd=None)
if len(history):
# due to broken pipe problems pass only first 10MB
- data = history[-1].std_out[0:10*1024]
+ data = history[-1].std_out[0:10*1024*1024]
cmd = Command(c)
out, err = cmd.run(data, timeout, kill_timeout, env, cwd)
View
10 test_envoy.py
@@ -1,6 +1,9 @@
import unittest
import envoy
+MB10 = 10 * 1024 * 1024
+
+
class SimpleTest(unittest.TestCase):
def test_input(self):
@@ -24,6 +27,13 @@ def test_quoted_args(self):
self.assertEqual(r.std_out.rstrip(), sentinel)
self.assertEqual(r.status_code, 0)
+ def test_std_out_size(self):
+ # call program with std_out size greater then 10MB
+ r = envoy.run('yes | head -c %d' % (MB10 + 1), timeout=1)
+ self.assertEqual(len(r.std_out), MB10)
+ self.assertEqual(r.status_code, 0)
+
+
class ConnectedCommandTests(unittest.TestCase):
def test_status_code(self):
Something went wrong with that request. Please try again.