Permalink
Browse files

Add code example to demonstrate proper string concatenation.

The text does a good job of explaining which route to take when
concatenating strings, but the mention of "join" might mean nothing to
beginners without a concrete example.
  • Loading branch information...
1 parent 50e6613 commit 62e59a57e48ca6a52c6ad649731a0cf324551e5b @kylerob kylerob committed Jun 14, 2012
Showing with 20 additions and 0 deletions.
  1. +20 −0 docs/writing/structure.rst
View
@@ -391,6 +391,26 @@ its parts, it is much more efficient to accumulate the parts in a list,
which is mutable, and then glue ('join') the parts together when the
full string is needed.
+**Bad**
+
+.. code-block:: python
+
+ # create a concatenated string from 0 to 19 (e.g. "012..1819")
+ nums = ""
+ for n in range(20):
+ nums += str(n) # slow and inefficient
+ print nums
+
+**Good**
+
+.. code-block:: python
+
+ # create a concatenated string from 0 to 19 (e.g. "012..1819")
+ nums = []
+ for n in range(20):
+ nums.append(str(n))
+ print "".join(nums) # much more efficient
+
Vendorizing Dependencies
------------------------

0 comments on commit 62e59a5

Please sign in to comment.