Make Session objects picklable #439

Closed
sharat87 opened this Issue Feb 18, 2012 · 5 comments

Projects

None yet

3 participants

@sharat87
Contributor

Currently, when we try to pickle a Session object, we get this:

  File "[...]python2.7/copy_reg.py", line 70, in _reduce_ex
    raise TypeError, "can't pickle %s objects" % base.__name__
TypeError: can't pickle lock objects

The Session objects can be made pickleable rather easily. If you are willing to accept this functionality, I can create a pull request. I showed the implementation on my blog post about this.

@Diaoul
Diaoul commented Feb 18, 2012

Broken link

@sharat87
Contributor

Sorry, fixed now.

@kennethreitz
Owner

Let's do it!

@sharat87
Contributor

I committed my changes and referred to this issue number in the commit message. Can you pull with that or should I create a new pull request (which creates a new issue I believe)?

Edit: Apparently there needs to be a pull request created.

@kennethreitz
Owner

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment