Do not set headers with None value #1921

Merged
merged 1 commit into from Mar 3, 2014

Projects

None yet

3 participants

@sigmavirus24
Collaborator
  • Regardless of whether they are on the session or not
  • Fixes #1920
@sigmavirus24 sigmavirus24 Do not set headers with None value
- Regardless of whether they are on the session or not
- Fixes #1920
d2f647c
@Lukasa Lukasa was assigned by sigmavirus24 Feb 14, 2014
@sigmavirus24
Collaborator

Assigning to @Lukasa for review and once past that, I will assign it to Kenneth.

@Lukasa
Collaborator
Lukasa commented Feb 14, 2014

LGTM. 👍

@Lukasa Lukasa assigned kennethreitz and unassigned Lukasa Feb 14, 2014
@sigmavirus24
Collaborator

FWIW, I think we used to do this back in 1.x but someone recently rewrote the merge_setting function (also they moved which file it is in so I couldn't find it at first =P) and they dropped this functionality. This is a backwards regression but I can understand if we'd rather let the user shoot themselves in the foot.

@kennethreitz kennethreitz merged commit 3c4b374 into kennethreitz:master Mar 3, 2014

1 check passed

Details default Merged build finished.
@kennethreitz
Owner

🍰

@sigmavirus24 sigmavirus24 deleted the sigmavirus24:fix-session-header-none branch Mar 5, 2014
@sigmavirus24
Collaborator

☕️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment