Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upCustom DST #2
Conversation
kennytm
force-pushed the
dyn-type-8
branch
from
274b1aa
to
2e9c454
Nov 11, 2018
kennytm
force-pushed the
dyn-type-8
branch
from
2e9c454
to
99e4b29
Nov 11, 2018
Centril
reviewed
Nov 12, 2018
Centril left a comment
|
Some typos mostly; (there are plenty left I think so you'll want to proof read this...) Comments were made as I read them so you might have addressed some bits in later parts of the RFC, for example re. |
text/0000-dyn-type.md Outdated
text/0000-dyn-type.md Outdated
text/0000-dyn-type.md Outdated
text/0000-dyn-type.md Outdated
text/0000-dyn-type.md Outdated
text/0000-dyn-type.md Outdated
text/0000-dyn-type.md Outdated
text/0000-dyn-type.md Outdated
text/0000-dyn-type.md Outdated
| The problem of generalizing `Metadata` is that it will plague every API it touches, e.g. | ||
|
|
||
| ```rust | ||
| fn metadata<T: ?Sized, P: PointerFamily>(dst: P::Pointer<T>) -> T::Metadata<P>; |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kennytm
Nov 12, 2018
Author
Owner
Align<2> could imply a type can simultaneously implement Align<1> + Align<2> + Align<4> + ...
This comment has been minimized.
This comment has been minimized.
Centril
Nov 12, 2018
Oooooops!
trait T<U: Align<Val = 2>> {
type V: PartialEq<U> + Align<Val = 2>,
}We already have associated consts so we can probably do it today.
Centril
and others
added some commits
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kennytm commentedNov 11, 2018
Rendered
(This is a completed and trimmed down version of https://github.com/kennytm/rfcs/tree/dyn-type/text/0000-dyn-type excluding stuff already handled by rust-lang#2580 and rust-lang#2310, and removing all placement-new stuff.)