Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links on table of content #57

Merged
merged 2 commits into from Jun 26, 2018
Merged

Fix broken links on table of content #57

merged 2 commits into from Jun 26, 2018

Conversation

matheus1lva
Copy link
Contributor

What: Fix broken markdown on table of contents (link)

Why: Users can go directly to the topic when clicking on the table of content.

How: Updating markdown properly to have a link to the correct location.

@kentcdodds
Copy link
Owner

Hmmm... The table of contents is generated. If you look at this PR you'll see the diff isn't showing your ToC changes because when you commit, the table is regenerated based on the headings. I'm guessing we'll need to change a heading so it isn't broken.

@kentcdodds
Copy link
Owner

Looks like the fact that there's a link in the heading is the problem. If you move the link to right below the heading with something like "Learn more" then that would fix it.

@matheus1lva
Copy link
Contributor Author

Oh... i did not pay attention to the regeneration of that... my bad. I'm going to rework that!

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Thanks

@kentcdodds kentcdodds merged commit d8be253 into kentcdodds:master Jun 26, 2018
@kentcdodds
Copy link
Owner

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants