Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumped cross-spawn to version 7.0.0 #211

Merged
merged 2 commits into from Sep 17, 2019

Conversation

@bibo5088
Copy link
Contributor

bibo5088 commented Sep 17, 2019

What: Bumped dependency cross-spawn to ^7.0.0

Why: cross-spawn 7.0.0 removed 2 dependencies but also removed compatibily with node.js 7 and lower.

How: Just changed the package.json

Checklist:

  • Documentation
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table N/A

Added a warning in README.md, should also update the badge but I don't know how.
This is a breaking change since it removes compatibility with node.js 7 and lower, so it requires a new major version.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #211 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #211   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          69     69           
  Branches       18     18           
=====================================
  Hits           69     69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a75fd0e...6d9d4e2. Read the comment docs.

@bibo5088 bibo5088 marked this pull request as ready for review Sep 17, 2019
Copy link
Owner

kentcdodds left a comment

Sounds good to me 👍 Thanks!

@kentcdodds kentcdodds merged commit 61ebf59 into kentcdodds:master Sep 17, 2019
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing a75fd0e...6d9d4e2
Details
codecov/project 100% remains the same compared to a75fd0e
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
bors bot added a commit to IMA-WorldHealth/bhima that referenced this pull request Sep 18, 2019
Merge #3892
3892: Update cross-env to the latest version 🚀 r=jniles a=greenkeeper[bot]


## The dependency [cross-env](https://github.com/kentcdodds/cross-env) was updated from `5.2.1` to `6.0.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

**Publisher:** [kentcdodds](https://www.npmjs.com/~kentcdodds)
**License:** MIT

<details>
<summary>Release Notes for v6.0.0</summary>

<p><a name="user-content-6.0.0"></a></p>
<h1><a href="https://urls.greenkeeper.io/kentcdodds/cross-env/compare/v5.2.1...v6.0.0">6.0.0</a> (2019-09-17)</h1>
<h3>Bug Fixes</h3>
<ul>
<li>bumped cross-spawn to version 7.0.0 (<a href="https://urls.greenkeeper.io/kentcdodds/cross-env/issues/211" data-hovercard-type="pull_request" data-hovercard-url="/kentcdodds/cross-env/pull/211/hovercard">#211</a>) (<a href="https://urls.greenkeeper.io/kentcdodds/cross-env/commit/61ebf59">61ebf59</a>)</li>
</ul>
<h3>BREAKING CHANGES</h3>
<ul>
<li>Drop support for Node.js &lt; 7.</li>
</ul>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 1 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/kentcdodds/cross-env/commit/61ebf5970e88e915a09e80d0858ca6344efaa3ae"><code>61ebf59</code></a> <code>fix: bumped cross-spawn to version 7.0.0 (#211)</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/kentcdodds/cross-env/compare/a75fd0ef17b94f002166f894c357a1dee02cc97e...61ebf5970e88e915a09e80d0858ca6344efaa3ae">full diff</a></p>
</details>

---

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴



Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com>
bors bot added a commit to IMA-WorldHealth/bhima that referenced this pull request Sep 18, 2019
Merge #3892
3892: Update cross-env to the latest version 🚀 r=jniles a=greenkeeper[bot]


## The dependency [cross-env](https://github.com/kentcdodds/cross-env) was updated from `5.2.1` to `6.0.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

**Publisher:** [kentcdodds](https://www.npmjs.com/~kentcdodds)
**License:** MIT

<details>
<summary>Release Notes for v6.0.0</summary>

<p><a name="user-content-6.0.0"></a></p>
<h1><a href="https://urls.greenkeeper.io/kentcdodds/cross-env/compare/v5.2.1...v6.0.0">6.0.0</a> (2019-09-17)</h1>
<h3>Bug Fixes</h3>
<ul>
<li>bumped cross-spawn to version 7.0.0 (<a href="https://urls.greenkeeper.io/kentcdodds/cross-env/issues/211" data-hovercard-type="pull_request" data-hovercard-url="/kentcdodds/cross-env/pull/211/hovercard">#211</a>) (<a href="https://urls.greenkeeper.io/kentcdodds/cross-env/commit/61ebf59">61ebf59</a>)</li>
</ul>
<h3>BREAKING CHANGES</h3>
<ul>
<li>Drop support for Node.js &lt; 7.</li>
</ul>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 1 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/kentcdodds/cross-env/commit/61ebf5970e88e915a09e80d0858ca6344efaa3ae"><code>61ebf59</code></a> <code>fix: bumped cross-spawn to version 7.0.0 (#211)</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/kentcdodds/cross-env/compare/a75fd0ef17b94f002166f894c357a1dee02cc97e...61ebf5970e88e915a09e80d0858ca6344efaa3ae">full diff</a></p>
</details>

---

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴



Co-authored-by: greenkeeper[bot] <23040076+greenkeeper[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.