New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect getElementById usage in README #132

Merged
merged 2 commits into from Oct 21, 2018

Conversation

Projects
None yet
2 participants
@campbellr
Contributor

campbellr commented Oct 21, 2018

What:

Fixed a minor typo in the examples that incorrectly called getElementById on document.body instead of document (Only the Document object has a getElementById method).

Why:

The example fails without the change.

How:

Checklist:

  • Documentation N/A
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table

campbellr added some commits Oct 21, 2018

Fix incorrect getElementById usage in README
The current example is broken because getElementById only works on
Document object, not the body.

@kentcdodds kentcdodds merged commit 91e8c5f into kentcdodds:master Oct 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kentcdodds

This comment has been minimized.

Owner

kentcdodds commented Oct 22, 2018

🎉 This PR is included in version 3.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kentcdodds kentcdodds added the released label Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment