Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setup-globals script to index.html #2

Merged
merged 1 commit into from Jan 10, 2020

Conversation

zacjones93
Copy link

@zacjones93 zacjones93 commented Jan 9, 2020

Bug Fix

CodeSandbox embed is broken due to no reference to setup-globals.js in index.html.

Affected lesson: Verify Custom JavaScript Tests with Jest

Codesandbox embed shows an empty square

Changes made

  • add script tag in 06-verify-custom-javascript-tests-with-jest index.html referencing setup-globals.js

Working code example

@@ -8,7 +8,7 @@
<body>
<div id="app"></div>
<p>Look in console.</p>
<script src="./setup-globals.js"></script>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added script!

Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 0a32d74 into kentcdodds:egghead-2018 Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants