Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rss feed #51

Open
kentcdodds opened this Issue Feb 26, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@kentcdodds
Copy link
Owner

kentcdodds commented Feb 26, 2019

Here's the code that used to be there: de5dd06

Waiting on (or need to contribute a fix to) this: ChristopherBiscardi/gatsby-mdx#295

@z0al

This comment has been minimized.

Copy link
Contributor

z0al commented Mar 20, 2019

After many attempts, I've limited the number of feeds to 25 items only. I think is actually more practical limit than 1000. The local build now works fine (will fail if you set the limit to +30).

But now I've other issues 😞

  1. First I can't get the site to work on Netlify.com, the build takes ages and just stops here:

Edit: removed the log since it's clearly useless.

  1. Also, the <content:encoded> tag is always empty now and I couldn't figure out why!!!:

https://github.com/z0al/kentcdodds.com/blob/495951a91a79b9ed9a2a8674039d855e393a00bf/gatsby-config.js#L163

Is there is something I'm not aware of?

@z0al

This comment has been minimized.

Copy link
Contributor

z0al commented Mar 20, 2019

Ok. After more than 25 mins, the build failed with this:

9:10:51 PM: Error: ENOSPC: System limit for number of file watchers reached, watch '/opt/build/repo/public/uses'
9:10:51 PM:     at FSWatcher.start (internal/fs/watchers.js:165:26)
9:10:51 PM:     at Object.watch (fs.js:1253:11)
9:10:51 PM:     at NodeWatcher.watchdir (/opt/build/repo/node_modules/sane/src/node_watcher.js:159:22)
9:10:51 PM:     at NodeWatcher.<anonymous> (/opt/build/repo/node_modules/sane/src/node_watcher.js:295:18)
9:10:51 PM:     at /opt/build/repo/node_modules/graceful-fs/polyfills.js:285:20
9:10:51 PM:     at FSReqWrap.oncomplete (fs.js:154:5)
9:10:51 PM: npm ERR! code ELIFECYCLE
9:10:51 PM: npm ERR! errno 1
9:10:51 PM: npm
9:10:51 PM: ERR!
9:10:51 PM:  kentcdodds.com@1.0.0 test:watch: `jest --watch`
@kentcdodds

This comment has been minimized.

Copy link
Owner Author

kentcdodds commented Mar 20, 2019

Thanks for working on it @z0al!

I'm fine with a limit of the latest 25 posts. But I still think that I'd like to fix perf issues because I don't want my blog deploys to take even longer than they already do. I think the real solution is figuring out how to optimize gatsby-mdx and not spawning a webpack build for every blog post to generate the RSS feed.

@z0al

This comment has been minimized.

Copy link
Contributor

z0al commented Mar 20, 2019

I think the real solution is figuring out how to optimize gatsby-mdx and not spawning a webpack build for every blog post to generate the RSS feed.

Agree. But I thought this would be a temporary fix since I really needed the RSS feeds.

Sorry, don't have the time to dig in this, gonna leave it for someone else.

@kentcdodds

This comment has been minimized.

Copy link
Owner Author

kentcdodds commented Mar 20, 2019

Gotcha. Sorry, I'm not going to enable the RSS feed if it adds so much time to my build :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.