Change behaviour regarding controlled mode #27
Conversation
| @@ -155,29 +155,28 @@ test('children can be an array (for preact support)', () => { | |||
|
|
|||
| test('onToggle gets called in controlled prop scenario', () => { | |||
| const spy = jest.fn() | |||
| const {wrapper} = setup({on: false, onToggle: spy}) | |||
| const {setOn, setOff, wrapper} = setup({on: false, onToggle: spy}) | |||
There was a problem hiding this comment.
I dont think I've edited this test when working on this PR - Ive done some branch changing, stashing etc so maybe this came from some other branch, gonna investigate it later
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 20 21 +1
Branches 8 8
=====================================
+ Hits 20 21 +1
Continue to review full report at Codecov.
|
|
Is there a blocker for this PR? |
|
Sorry, this slipped away from me somehow. Also I never even used this project (it was an experiment/demo) so I'm totally the wrong person to maintain it. Anyone want to take it over? |
|
No worries. At the company I'm working for we use this library and we make copious use of the type of patterns promulgated here. 😀 @kentcdodds I'd be interested in helping to maintain this in case others are in the same boat. |
|
Totally, it's all yours @therealparmesh. To transition this over to you, I'm going to remove my npm and github token from travis which will disable the auto-releases. You can re-enable that yourself if you like. Please let me know your npm username and I'll add you as a collaborator there. This may also be helpful to you: https://kcd.im/write-oss Let me know if you have any other questions. |
|
@kentcdodds I will do my best to find other quality maintainers and to keep this to the standard that you're setting. My npm username is therealparmesh. Thank you! 👍 |
|
Awesome. I've added you to npm and github. I'm going to stop watching the repo now. Good luck! |
|
@Andarist Do you still think this PR is worth moving forward on? |
Possible changes regarding - #26