From 56ba2021d483325a3b817faca1af5353173349f9 Mon Sep 17 00:00:00 2001 From: Kent Fredric Date: Sat, 10 Sep 2016 17:56:52 +1200 Subject: [PATCH] Stop recommending ConfigDumper and instead, recommend its removal --- Changes | 3 +++ lib/Dist/Zilla/Plugin/Author/KENTNL/RecommendFixes.pm | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/Changes b/Changes index 17983d9..3682e93 100644 --- a/Changes +++ b/Changes @@ -1,6 +1,9 @@ Release history for Dist-Zilla-Plugin-Author-KENTNL-RecommendFixes {{$NEXT}} + [Checks] + - Derecommend use of ConfigDumper, it was a nice idea, but the dependency and test complexity I can do without. + [Dependencies::Stats] - Dependencies changed since 0.005001, see misc/*.deps* for details - develop: +2 ↑1 (suggests: ↑1) diff --git a/lib/Dist/Zilla/Plugin/Author/KENTNL/RecommendFixes.pm b/lib/Dist/Zilla/Plugin/Author/KENTNL/RecommendFixes.pm index a5d9f08..6d4b5fc 100644 --- a/lib/Dist/Zilla/Plugin/Author/KENTNL/RecommendFixes.pm +++ b/lib/Dist/Zilla/Plugin/Author/KENTNL/RecommendFixes.pm @@ -492,7 +492,7 @@ sub dzil_plugin_check { my (@plugins) = grep { $_->stringify =~ /\Alib\/Dist\/Zilla\/Plugin\//msx } @{ $self->libfiles }; return unless @plugins; for my $plugin (@plugins) { - $assert->should( have_line => $plugin, _plugin_re('Dist+Zilla+Util+ConfigDumper') ); + $assert->should_not( have_line => $plugin, _plugin_re('Dist+Zilla+Util+ConfigDumper') ); } return unless $self->tdir; return unless @{ $self->tfiles };