Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: ForestNew throws an error and key bindings don't work but ForestOpen does not #2

Closed
3 tasks done
kai-coo-per opened this issue Dec 28, 2023 · 11 comments
Closed
3 tasks done
Labels
bug Something isn't working

Comments

@kai-coo-per
Copy link

Did you check docs and existing issues?

  • I have read all the plugin docs
  • I have searched the existing issues
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

0.9.4

Operating system/version

MacOS 13.4

Describe the bug

Neither :ForestNew command, nor its key bindings are working properly on my machine. However, :Forestpen is, and its key bindings are just fine. When activating :ForestNew, the "Select one of" window pops up but then this error appears. Not sure what to do about this.

Error executing vim.schedule lua callback: ...im/site/pack/packer/start/forester.nvim/lua/forester.lua:20: attempt to co
ncatenate a nil value
stack traceback:
...im/site/pack/packer/start/forester.nvim/lua/forester.lua:20: in function <...im/site/pack/packer/start/forest
er.nvim/lua/forester.lua:19>

Steps To Reproduce

  1. Call :ForestNew
  2. Type in desired name of tree

Expected Behavior

Tree generation and to take me to that tree.

@kai-coo-per kai-coo-per added the bug Something isn't working label Dec 28, 2023
@kentookura
Copy link
Owner

kentookura commented Dec 29, 2023

What version of forester are you on? This feature made use of a feature I had implemented on my branch of forester, which was only merged yesterday. Please try again using the latest version of forester.

@kai-coo-per
Copy link
Author

I'm on forester 2.5.1

@kentookura
Copy link
Owner

How did you install it? If you installed it with opam, then the newest features are not part of your release.

@kai-coo-per
Copy link
Author

Yes I installed it with opam. I guess I need to do something else?

@kentookura
Copy link
Owner

This commit is what added the feature:
https://git.sr.ht/~jonsterling/ocaml-forester/commit/faad8193b27db19e191e22cdecccdcb2492b8adb
I just saw that Jon released forester 3.0.0 yesterday, the feature is part of that release

@dannypsnl
Copy link
Collaborator

And you should update a more recently version due to a bug just fixed a few hours ago XD.

@kentookura
Copy link
Owner

I also fixed the typo in the command name

@kentookura kentookura changed the title bug: ForestNew throws an error and key bindings don't work but Forestpen does not bug: ForestNew throws an error and key bindings don't work but ForestOpen does not Dec 29, 2023
@kai-coo-per
Copy link
Author

Just updated forester to the latest version. Now the "Select one of" box is not empty and is populated with an already present tree prefix, but I'm having the same issue as before.

@kentookura
Copy link
Owner

What is the output of the command forester new --prefix foo --dir trees?

@kai-coo-per
Copy link
Author

So that specific command returns an error:

forester: required option --dest is missing Usage: forester new [OPTION]… Try 'forester new --help' or 'forester --help' for more information.

@kentookura
Copy link
Owner

I hadn't updated the plugin to use the new version of forester. Feel free to reopen if there are any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants