Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Potential typeface injection #142

Closed
veradrawer opened this issue Jan 22, 2022 · 3 comments
Closed

[BUG] Potential typeface injection #142

veradrawer opened this issue Jan 22, 2022 · 3 comments
Labels

Comments

@veradrawer
Copy link

@veradrawer veradrawer commented Jan 22, 2022

I'm using Obsidian on both Desktop and App with the Minimal theme, and set "Inter" my preferred typeface.
I was surprised when I found that in the App the typeface was also synced. But then I striked on those things that ruin the experience.
With the Minimal theme (tested with Default and California Coast) Inter has some kind of conflicts with its italic version. The text rendered looks like a 700 instead of the preffered value. There are no css snippets enabled for this test.

Tweaking with the css does not work, so I ended up concluding that the theme was fetching Inter from somewhere and overriding my installed copy or something even weirder. I can confirm this happens in both Source Mode and Live Edit.

imagen
Here we can see a paragraph with fat italics in Reading Mode.

imagen
The text is dealing with the same issue in Source Mode.

imagen
I confirm with the Developer Tools if somehow this is set to 700 or so. Nope.

imagen
Ironically, manually changing the value to 700 affects the rest of the body. Same thing with 900.

imagen
Something interesting. When I set the weight value to the absolute minimum (100), the italics are showing what seems to be an additional weight. They appear like 400 now!

imagen
Yup, body weight italics are fine.

imagen
There isn't any weight change with 500. This is where I start thinking something is overriding my installed fonts. I confirm I can use Inter 500 on any other app without issue.

imagen
With California Coast.

imagen
And finally with the Obsidian Default theme.

imagen
So, Okay, I have no idea what is going on. At this point I enable Safe mode and start checking. This changes the font to Segoe as the Style Settings plugin was disabled. I manually change the font to Inter again, just to check. And there is. Still.
NOTE: Segoe UI Bold Italic is not afected, just the text set in Inter is. I can use whatever typography I see fit but Inter. Obsidian won't let me use all installed weights of this typeface.

Help, please.

To reproduce
Steps to reproduce the behavior:

  1. Install the Minimal Theme
  2. Install Inter from Google Fonts
  3. Install Style Settings Plugin in Obsidian
  4. Set "Inter" as default font

Expected behavior
Bold Italics are the same weight as bold.

@veradrawer veradrawer added the bug label Jan 22, 2022
@veradrawer
Copy link
Author

@veradrawer veradrawer commented Jan 22, 2022

imagen
This is a screenshot from my phone, as you can see, this happens across devices.
I have not installed Inter in my phone.

@veradrawer
Copy link
Author

@veradrawer veradrawer commented Jan 22, 2022

This issue is now also posted on the Obsidian Forum

@kepano
Copy link
Owner

@kepano kepano commented Jan 22, 2022

This is not a Minimal theme issue because it also happens with the default theme.

The issue seems to be that the version of Inter that ships with Obsidian doesn't contain the 600 weight italic variation.

The default bold weight in Obsidian is 700, whereas the default bold weight in Minimal is 600. That's why there is a discrepancy.

If you use a snippet to set --bold-weight:700 the fonts will be consistent in bold vs. bold italic

@kepano kepano closed this Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants