From 55f74dcd22db624ec0ba6bdf024b035f7d616059 Mon Sep 17 00:00:00 2001 From: Shan He Date: Sun, 6 Dec 2020 22:04:59 -0800 Subject: [PATCH] [Enhancement] added check for oldLayerData (#1357) Signed-off-by: Shan He --- src/layers/base-layer.js | 3 ++- src/layers/layer-text-label.js | 7 ++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/layers/base-layer.js b/src/layers/base-layer.js index c2703831a9..d4530c82b8 100644 --- a/src/layers/base-layer.js +++ b/src/layers/base-layer.js @@ -884,7 +884,8 @@ export default class Layer { } let data = []; - if (!triggerChanged.getData) { + + if (!triggerChanged.getData && oldLayerData && oldLayerData.data) { // same data data = oldLayerData.data; } else { diff --git a/src/layers/layer-text-label.js b/src/layers/layer-text-label.js index 373b143fa1..50433182fd 100644 --- a/src/layers/layer-text-label.js +++ b/src/layers/layer-text-label.js @@ -70,7 +70,12 @@ export const formatTextLabelData = ({textLabel, triggerChanged, oldLayerData, da const getText = textLabelAccessor(tl); let characterSet; - if (!triggerChanged[`getLabelCharacterSet-${i}`]) { + if ( + !triggerChanged[`getLabelCharacterSet-${i}`] && + oldLayerData && + oldLayerData.textLabels && + oldLayerData.textLabels[i] + ) { characterSet = oldLayerData.textLabels[i].characterSet; } else { const allLabels = tl.field ? data.map(getText) : [];