[RFC] table class RFC #1109
Merged
[RFC] table class RFC #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shan He <heshan0131@gmail.com>
ibgreen
approved these changes
May 11, 2020
docs/RFC/table-class.md
Outdated
| table.gpuFilter | ||
| ``` | ||
|
|
||
| 3. `getValue(columnName, rowIdx)` |
There was a problem hiding this comment.
Nit: Numbering seems out of order.
Signed-off-by: Shan He <heshan0131@gmail.com>
Signed-off-by: Shan He <heshan0131@gmail.com>
|
@nrabinowitz fyi |
manassra
pushed a commit
that referenced
this pull request
Jun 18, 2020
* Add table class rfc to summarize kepler dataset structure Signed-off-by: Wesam Manassra <wesam.manassra@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shan He heshan0131@gmail.com