Load: extract extensions from loader objects #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ib Green <ib@unfolded.ai>
Signed-off-by: Ib Green <ib@unfolded.ai>
heshan0131
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ib Green ib@unfolded.ai
UI and functionality now dynamically adapts if additional loaders are supplied.
upload-file.jsshould not "know about" loaders.gl objects, so placed extensions and filename extraction in modal-container - it is still part of the UI but better since seems to contain a lot of glue code and knows about a lot of things and fires of actions.But as discussed, I should probably move the new selectors into the vis-state-reducer so that we can keep the knowledge of how to extract those things from loaders.gl loaders out of the UI.