Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

filter message when deps_mode="none" #236

Merged
merged 1 commit into from

2 participants

@fperrad

On Buildroot, we call luarocks make --deps-mode=none --keep foo.rockspec
So, the message about missing dependency is confusing.

Warning: skipping dependency checks.
...
Missing dependency for cgilua 5.1.4-1: luafilesystem >= 1.5.0
@fperrad fperrad filter message when deps_mode="none"
On Buildroot, we call `luarocks make --deps-mode=none --keep foo.rockspec`
So, the message about missing dependency is confusing.

```
Warning: skipping dependency checks.
...
Missing dependency for cgilua 5.1.4-1: luafilesystem >= 1.5.0
```
7e2fd86
@hishamhm hishamhm merged commit 2bcc5e5 into keplerproject:master
@hishamhm
Owner

Merged, thank you!!

@fperrad fperrad referenced this pull request from a commit in fperrad/br
@fperrad fperrad luarocks: move the option --deps-mode
from `luarocks make` command to the LuaRocks config file.

This change and the merge of PR keplerproject/luarocks#236
in LuaRocks 2.2.0 avoid the confusing message "Missing dependency"
459f4eb
@fperrad fperrad referenced this pull request from a commit in fperrad/br
@fperrad fperrad luarocks: move the option --deps-mode
from `luarocks make` command to the LuaRocks config file.

This change and the merge of PR keplerproject/luarocks#236
in LuaRocks 2.2.0 avoid the confusing message "Missing dependency"
91aa4cd
@fperrad fperrad referenced this pull request from a commit in fperrad/br
@fperrad fperrad luarocks: move the option --deps-mode
The option moves from `luarocks make` command to the LuaRocks config file.

This change and the merge of PR keplerproject/luarocks#236
in LuaRocks 2.2.0 avoids the confusing message "Missing dependency"

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
6d1bdec
@g5nnnnn g5nnnnn referenced this pull request from a commit in g5nnnnn/buildroot
@fperrad fperrad luarocks: move the option --deps-mode
The option moves from `luarocks make` command to the LuaRocks config file.

This change and the merge of PR keplerproject/luarocks#236
in LuaRocks 2.2.0 avoids the confusing message "Missing dependency"

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
5363cf1
@philenotfound philenotfound referenced this pull request from a commit in philenotfound/buildroot-cr15wi
@fperrad fperrad luarocks: move the option --deps-mode
The option moves from `luarocks make` command to the LuaRocks config file.

This change and the merge of PR keplerproject/luarocks#236
in LuaRocks 2.2.0 avoids the confusing message "Missing dependency"

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
f1031a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 1, 2014
  1. @fperrad

    filter message when deps_mode="none"

    fperrad authored
    On Buildroot, we call `luarocks make --deps-mode=none --keep foo.rockspec`
    So, the message about missing dependency is confusing.
    
    ```
    Warning: skipping dependency checks.
    ...
    Missing dependency for cgilua 5.1.4-1: luafilesystem >= 1.5.0
    ```
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 2 deletions.
  1. +1 −2  src/luarocks/manif.lua
View
3  src/luarocks/manif.lua
@@ -1,4 +1,3 @@
-
--- Module for handling manifest files and tables.
-- Manifest files describe the contents of a LuaRocks tree or server.
-- They are loaded into manifest tables, which are then used for
@@ -253,7 +252,7 @@ local function update_dependencies(manifest, deps_mode)
for miss, err in pairs(missing) do
if miss == current then
util.printerr("Tree inconsistency detected: "..current.." has no rockspec. "..err)
- else
+ elseif deps_mode ~= "none" then
util.printerr("Missing dependency for "..pkg.." "..version..": "..miss)
end
end
Something went wrong with that request. Please try again.