New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use specified Content-Length if provided #20

Merged
merged 1 commit into from Jan 29, 2014

Conversation

Projects
None yet
2 participants
@ignacio
Member

ignacio commented Sep 25, 2013

This change allows to test how endpoints deal with invalid POST (advertising more or less bytes than actually sent, etc).

Use specified Content-Length if provided
This change allows to test how endpoints deal with invalid POST (advertising more or less bytes than actually sent, etc).
@ignacio

This comment has been minimized.

Show comment
Hide comment
@ignacio

ignacio Nov 8, 2013

Member

Any chance this gets reviewed?

Member

ignacio commented Nov 8, 2013

Any chance this gets reviewed?

@hishamhm

This comment has been minimized.

Show comment
Hide comment
@hishamhm

hishamhm Jan 29, 2014

Member

Not an expert, but I guess this has potential to break existing applications, doesn't it? If users are relying on the variable to contain the actual length, this will change the behavior...

Having said that, I have no idea what the actual behavior should be.

(I'm just taking a look at the pending pull requests to see which ones we integrate to get a new release/rockspec out)

Member

hishamhm commented Jan 29, 2014

Not an expert, but I guess this has potential to break existing applications, doesn't it? If users are relying on the variable to contain the actual length, this will change the behavior...

Having said that, I have no idea what the actual behavior should be.

(I'm just taking a look at the pending pull requests to see which ones we integrate to get a new release/rockspec out)

@ignacio

This comment has been minimized.

Show comment
Hide comment
@ignacio

ignacio Jan 29, 2014

Member

This is just to mock requests that triggers error conditions in a server. This is no way affect "production" code. Any testing code that may be affected by this change is code that wasn't working as expected anyway (i.e. the header was set but it wasn't being used anyway).

Member

ignacio commented Jan 29, 2014

This is just to mock requests that triggers error conditions in a server. This is no way affect "production" code. Any testing code that may be affected by this change is code that wasn't working as expected anyway (i.e. the header was set but it wasn't being used anyway).

@hishamhm

This comment has been minimized.

Show comment
Hide comment
@hishamhm

hishamhm Jan 29, 2014

Member

Ah, ok!

Member

hishamhm commented Jan 29, 2014

Ah, ok!

hishamhm added a commit that referenced this pull request Jan 29, 2014

Merge pull request #20 from ignacio/patch-1
Use specified Content-Length if provided

@hishamhm hishamhm merged commit 1107877 into keplerproject:master Jan 29, 2014

@ignacio ignacio deleted the ignacio:patch-1 branch Jan 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment