New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows to specify a domain when deleting a cookie. #31

Merged
merged 2 commits into from Mar 21, 2014

Conversation

Projects
None yet
2 participants
@ignacio
Member

ignacio commented Jan 28, 2014

When a cookie has been set with a given domain (i.e. domain="example.com"), subsequent attempts to delete it will be ignored by the browser if the same domain is not provided.

So a 'domain' parameter is added to the 'delete_cookie' method in order to be able to delete those cookies.

ignacio added some commits Jan 28, 2014

Allows to specify a domain when deleting a cookie.
When a cookie has been set with a given domain (i.e. domain="example.com"), subsequent attempts to delete it will be ignored by the browser if the same domain is not provided.

So a 'domain' parameter is added to the 'delete_cookie' method in order to be able to delete those cookies.
@hishamhm

This comment has been minimized.

Show comment
Hide comment
@hishamhm

hishamhm Jan 29, 2014

Member

Any compatibility concerns about merging this one?

Member

hishamhm commented Jan 29, 2014

Any compatibility concerns about merging this one?

@ignacio

This comment has been minimized.

Show comment
Hide comment
@ignacio

ignacio Jan 29, 2014

Member

None. This is a new optional parameter. If not present, nothing will change in the Set-Cookie responses as they are now.

We may want a few days in case anyone else wants to chime in.

Member

ignacio commented Jan 29, 2014

None. This is a new optional parameter. If not present, nothing will change in the Set-Cookie responses as they are now.

We may want a few days in case anyone else wants to chime in.

@ignacio

This comment has been minimized.

Show comment
Hide comment
@ignacio

ignacio Mar 20, 2014

Member

Well, a few days have passed. Should we merge this?

Member

ignacio commented Mar 20, 2014

Well, a few days have passed. Should we merge this?

hishamhm added a commit that referenced this pull request Mar 21, 2014

Merge pull request #31 from ignacio/patch-2
Allows to specify a domain when deleting a cookie.

@hishamhm hishamhm merged commit eed8338 into keplerproject:master Mar 21, 2014

@ignacio ignacio referenced this pull request Mar 21, 2014

Merged

Prepares 1.6.1 release #33

@ignacio ignacio deleted the ignacio:patch-2 branch Mar 21, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment