Skip to content

[fix] Build warning on image optimization#39

Closed
sahadat-sk wants to merge 2 commits into
keploy:mainfrom
sahadat-sk:remove-build-warnings
Closed

[fix] Build warning on image optimization#39
sahadat-sk wants to merge 2 commits into
keploy:mainfrom
sahadat-sk:remove-build-warnings

Conversation

@sahadat-sk
Copy link
Copy Markdown
Contributor

@sahadat-sk sahadat-sk commented Apr 2, 2024

Fixes issue : #1770

Changes:

  • Use next/image in pages, 'component/header.tsx', 'pages/index.tsx', and 'components/tweets.tsx'
  • Install the sharp package as recommended by next.js

@sahadat-sk
fix: build warning on image optimization
73f8111 
Signed-off-by: sahadat-sk <mss.21U10442@btech.nitdgp.ac.in>
@nehagup nehagup requested a review from Hermione2408 April 3, 2024 05:56
Hermione2408
Hermione2408 suggested changes Apr 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Hermione2408 Hermione2408 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sahadat-sk please revert back linting changes It can cause conflicts.The build is working fine now!

@sahadat-sk
fix: revert linting changes
7f81335 
Signed-off-by: sahadat-sk <mss.21U10442@btech.nitdgp.ac.in>
@sahadat-sk
Copy link
Copy Markdown
Contributor Author

sahadat-sk commented Apr 3, 2024

Hey @sahadat-sk please revert back linting changes It can cause conflicts.The build is working fine now!

I have reverted the linting changes, can you please review it?

@Hermione2408
Copy link
Copy Markdown
Contributor

Hermione2408 commented Apr 4, 2024

Hey @sahadat-sk please revert back linting changes It can cause conflicts.The build is working fine now!

I have reverted the linting changes, can you please review it?

Hey @sahadat-sk this issue is now resolved with PR #38

@Hermione2408
Copy link
Copy Markdown
Contributor

Hermione2408 commented Apr 5, 2024

Hey @sahadat-sk please revert back linting changes It can cause conflicts.The build is working fine now!

I have reverted the linting changes, can you please review it?

Hey @sahadat-sk this issue is now resolved with PR #38

Hey @sahadat-sk I am closing this PR as it is fixed now with PR #38

slayerjain pushed a commit that referenced this pull request May 5, 2026
@nehagup
fix(seo): decode WordPress numeric HTML entities in HowTo schema
39e8859 
stripHtml() was only decoding the named entity set (&amp;, &lt;, etc.)
plus &#39;, so curly apostrophes (&#8217;), en/em dashes (&#8211; /
&#8212;), and curly quotes (&#8220; / &#8221;) leaked into HowTo step
text as literal entity strings. Search engines and the rich-results test
treat that as broken markup. Mirror the decode list from utils/seo.ts
so the JSON-LD and the meta description stay consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Hermione2408 Hermione2408 Hermione2408 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sahadat-sk @Hermione2408