fix: unknown path problem in docker #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
gouravkrosx
reviewed
Jan 26, 2024
cmd/record.go
Outdated
| return nil | ||
| } | ||
| currentDir := strings.TrimSpace(string(out)) | ||
| fmt.Println("THis is the path", path) |
gouravkrosx
reviewed
Jan 26, 2024
cmd/test.go
Outdated
| return nil | ||
| } | ||
| currentDir := strings.TrimSpace(string(out)) | ||
| fmt.Println("THis is the path", path) |
There was a problem hiding this comment.
Make this also a debug log.
|
The user-provided path should be logged in each error. |
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Signed-off-by: Pranshu Srivastava <iampranshu24@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you've made
Added a check for the path in case of docker, if the path is not a subdirectory of the current path then we do not record
Fixes: #1411
Type of change
Checklist: