Branch: picard-259
-
Refactor code to find enabled scripts to a function
kepstin committedMar 5, 2018 The enabled_tagger_scripts_texts() function creates a list of enabled functions which other code can use directly, abstracting away the checks to see if tagger script is enabled, and whether each individual script is enabled (and non-empty).
-
Allow tagger script to access file metadata
kepstin committedMar 5, 2018 Fixes PICARD-259 (and associated sub-tickets) This moves the taggerscript evaluation to happen when a file is matched (i.e. when a file is added to a track), where it has access to the both the file metadata *and* the track metadata. In order to ensure that the titles in the user interface are correct, this is done by saving an extra copy of the original musicbrainz metadata in track.orig_metadata. The taggerscript is run as per normal on track.metadata, but the file matching will use track.orig_metadata and re-run the taggerscript on the merged data.
-
Merge pull request metabrainz#858 from zas/infodialog_cleanup
zas committedMar 4, 2018 InfoDialog: reduce code redundancy, subclassing QWidget
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits -
Store image size in a class attribute
zas committedMar 4, 2018 -
InfoDialog: adjust row's height according to cover art widget height
zas committedMar 4, 2018 It prevents the image to be vertically truncated
-
InfoDialog: reduce code redundancy, subclassing QWidget
zas committedMar 4, 2018 -
Merge pull request metabrainz#857 from zas/saverestore
zas committedMar 4, 2018 Generic class to save/restore dialog geometry, code simplification
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits -
Introduce and use PreserveGeometry class and drop a lot useless code
zas committedMar 3, 2018 It also adds save/restore geometry to: - password dialog - info dialogs (fix PICARD-1093) - tags from filenames dialog - edit tags dialog Each geometry is saved as "geometry_<class_name>" persist option (ByteArray())
Verified
This commit was signed with a verified signature.zas Laurent Monin
GPG key ID: D859F01B646C07A7 Learn about signing commits
-
Merge pull request metabrainz#855 from zas/sslversion
zas committedMar 3, 2018 Display SSL version string
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
-
Verified
This commit was signed with a verified signature.zas Laurent Monin
GPG key ID: D859F01B646C07A7 Learn about signing commits -
Fix Exception when removing last script in Options/Scripting
zas committedMar 2, 2018 Traceback (most recent call last): File "./picard/ui/options/scripting.py", line 258, in <lambda> list_widget.set_remove_connection(lambda: self.remove_from_list_of_scripts(self.ui.script_list.row(item))) File "./picard/ui/options/scripting.py", line 323, in remove_from_list_of_scripts item.setSelected(True) AttributeError: 'NoneType' object has no attribute 'setSelected'
Verified
This commit was signed with a verified signature.zas Laurent Monin
GPG key ID: D859F01B646C07A7 Learn about signing commits -
zas committed
Mar 2, 2018 Verified
This commit was signed with a verified signature.zas Laurent Monin
GPG key ID: D859F01B646C07A7 Learn about signing commits
-
Use faster string concatenation instead of format to build key
zas committedMar 1, 2018 Forgotten in metabrainz#854
Verified
This commit was signed with a verified signature.zas Laurent Monin
GPG key ID: D859F01B646C07A7 Learn about signing commits -
Merge pull request metabrainz#854 from sambhav/picard_1204
samj1912 committedMar 1, 2018 PICARD-1204: Read and dump values to QSettings only when necessary
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits -
Fix variable names and optimize key building
samj1912 committedMar 1, 2018 -
Process modifications to QSettings immediately
samj1912 committedMar 1, 2018 -
Make sure only relevant keys are loaded
samj1912 committedMar 1, 2018 -
PICARD-1204: Read and dump values to QSettings only when necessary
samj1912 committedMar 1, 2018 Reading and dumping too often from QSettings causes picard to lock up. This makes sure we only read on start and dump on change.
-
Merge pull request metabrainz#847 from vishichoudhary/two-three
zas committedFeb 28, 2018 Use python3 super function instead of calling by class name
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits -
vishichoudhary committed
Feb 27, 2018 -
Merge pull request metabrainz#852 from zas/PICARD-1202
zas committedFeb 28, 2018 PICARD-1202: only use current item if there's actually one
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits -
Merge branch 'master' into PICARD-1202
zas committedFeb 28, 2018 Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits -
Merge pull request metabrainz#851 from zas/no_restore
zas committedFeb 28, 2018 PICARD-1201: Add -N/--no-restore option to not restore persisted sizes and positions
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits -
PICARD-1202: only use current item if there's actually one
zas committedFeb 28, 2018 It prevents following error: Traceback (most recent call last): File "/usr/lib/python3.6/site-packages/picard/ui/metadatabox.py", line 292, in contextMenuEvent column = item.column() AttributeError: 'NoneType' object has no attribute 'column'
Verified
This commit was signed with a verified signature.zas Laurent Monin
GPG key ID: D859F01B646C07A7 Learn about signing commits -
Merge branch 'master' into no_restore
zas committedFeb 28, 2018 Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits -
Merge pull request metabrainz#849 from sambhav/dsfui
samj1912 committedFeb 28, 2018 PICARD-1203: Do not show un-supported tags in UI
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits -
Refactor format tests to remove unsupported tags automatically
samj1912 committedFeb 27, 2018 -
Refactor supports_tag as a class method and update unsupported tags
samj1912 committedFeb 27, 2018 -
Add -N/--no-restore option to not restore persisted sizes and positions
zas committedFeb 27, 2018 It is useful for: - users having UI issues on startup (too small, too big, out of screen, etc...) - devs for testing purposes
Verified
This commit was signed with a verified signature.zas Laurent Monin
GPG key ID: D859F01B646C07A7 Learn about signing commits -
samj1912 committed
Feb 27, 2018 -
Do not show un-supported DSF tags in UI
samj1912 committedFeb 26, 2018
-
Merge pull request metabrainz#850 from zas/splitter
zas committedFeb 27, 2018 PICARD-1200: fix Options tree pane resizing
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits -
PICARD-1200: fix Options tree pane resizing
zas committedFeb 27, 2018 Size policy of both panes plus the minimum width enforced for the tree pane are responsible of the issue Set horizontal policies to Ignored, and use QSplitter.setSizes() to set a smart default. After this change, it is possible to move the splitter smoothly.
Verified
This commit was signed with a verified signature.zas Laurent Monin
GPG key ID: D859F01B646C07A7 Learn about signing commits
-
Merge pull request metabrainz#835 from zas/dsf
zas committedFeb 26, 2018 PICARD-1187: Add DSF file support
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits -
zas committed
Feb 26, 2018 Verified
This commit was signed with a verified signature.zas Laurent Monin
GPG key ID: D859F01B646C07A7 Learn about signing commits