Permalink
Branch: picard-259
Commits on Mar 6, 2018
  1. Refactor code to find enabled scripts to a function

    kepstin committed Mar 5, 2018
    The enabled_tagger_scripts_texts() function creates a list of enabled
    functions which other code can use directly, abstracting away the checks
    to see if tagger script is enabled, and whether each individual script
    is enabled (and non-empty).
Commits on Mar 5, 2018
  1. Allow tagger script to access file metadata

    kepstin committed Mar 5, 2018
    Fixes PICARD-259 (and associated sub-tickets)
    
    This moves the taggerscript evaluation to happen when a file is matched
    (i.e. when a file is added to a track), where it has access to the both
    the file metadata *and* the track metadata.
    
    In order to ensure that the titles in the user interface are correct,
    this is done by saving an extra copy of the original musicbrainz
    metadata in track.orig_metadata. The taggerscript is run as per normal
    on track.metadata, but the file matching will use track.orig_metadata
    and re-run the taggerscript on the merged data.
Commits on Mar 4, 2018
  1. Merge pull request metabrainz#858 from zas/infodialog_cleanup

    zas committed Mar 4, 2018
    InfoDialog: reduce code redundancy, subclassing QWidget
  2. InfoDialog: adjust row's height according to cover art widget height

    zas committed Mar 4, 2018
    It prevents the image to be vertically truncated
  3. Merge pull request metabrainz#857 from zas/saverestore

    zas committed Mar 4, 2018
    Generic class to save/restore dialog geometry, code simplification
  4. Introduce and use PreserveGeometry class and drop a lot useless code

    zas committed Mar 3, 2018
    It also adds save/restore geometry to:
    - password dialog
    - info dialogs (fix PICARD-1093)
    - tags from filenames dialog
    - edit tags dialog
    
    Each geometry is saved as "geometry_<class_name>" persist option (ByteArray())
Commits on Mar 3, 2018
  1. Merge pull request metabrainz#855 from zas/sslversion

    zas committed Mar 3, 2018
    Display SSL version string
Commits on Mar 2, 2018
  1. Display SSL version string

    zas committed Mar 2, 2018
    Example: "SSL OpenSSL 1.0.2g  1 Mar 2016"
  2. Fix Exception when removing last script in Options/Scripting

    zas committed Mar 2, 2018
    Traceback (most recent call last):
      File "./picard/ui/options/scripting.py", line 258, in <lambda>
        list_widget.set_remove_connection(lambda: self.remove_from_list_of_scripts(self.ui.script_list.row(item)))
      File "./picard/ui/options/scripting.py", line 323, in remove_from_list_of_scripts
        item.setSelected(True)
    AttributeError: 'NoneType' object has no attribute 'setSelected'
  3. Regenerate picard.pot

    zas committed Mar 2, 2018
Commits on Mar 1, 2018
  1. Merge pull request metabrainz#854 from sambhav/picard_1204

    samj1912 committed Mar 1, 2018
    PICARD-1204: Read and dump values to QSettings only when necessary
  2. PICARD-1204: Read and dump values to QSettings only when necessary

    samj1912 committed Mar 1, 2018
    Reading and dumping too often from QSettings causes picard to lock up.
    This makes sure we only read on start and dump on change.
Commits on Feb 28, 2018
  1. Merge pull request metabrainz#847 from vishichoudhary/two-three

    zas committed Feb 28, 2018
    Use python3 super function instead of calling by class name
  2. use python3 super()

    vishichoudhary committed Feb 27, 2018
  3. Merge pull request metabrainz#852 from zas/PICARD-1202

    zas committed Feb 28, 2018
    PICARD-1202: only use current item if there's actually one
  4. Merge pull request metabrainz#851 from zas/no_restore

    zas committed Feb 28, 2018
    PICARD-1201: Add -N/--no-restore option to not restore persisted sizes and positions
  5. PICARD-1202: only use current item if there's actually one

    zas committed Feb 28, 2018
    It prevents following error:
    Traceback (most recent call last):
    File "/usr/lib/python3.6/site-packages/picard/ui/metadatabox.py", line 292, in contextMenuEvent
    column = item.column()
    AttributeError: 'NoneType' object has no attribute 'column'
  6. Merge pull request metabrainz#849 from sambhav/dsfui

    samj1912 committed Feb 28, 2018
    PICARD-1203: Do not show un-supported tags in UI
  7. Add -N/--no-restore option to not restore persisted sizes and positions

    zas committed Feb 27, 2018
    It is useful for:
    - users having UI issues on startup (too small, too big, out of screen, etc...)
    - devs for testing purposes
Commits on Feb 27, 2018
  1. Merge pull request metabrainz#850 from zas/splitter

    zas committed Feb 27, 2018
    PICARD-1200: fix Options tree pane resizing
  2. PICARD-1200: fix Options tree pane resizing

    zas committed Feb 27, 2018
    Size policy of both panes plus the minimum width enforced for the tree pane are responsible of the issue
    
    Set horizontal policies to Ignored, and use QSplitter.setSizes() to set a smart default.
    After this change, it is possible to move the splitter smoothly.
Commits on Feb 26, 2018
  1. Merge pull request metabrainz#835 from zas/dsf

    zas committed Feb 26, 2018
    PICARD-1187: Add DSF file support
  2. Add DSF test

    zas committed Feb 26, 2018