This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
feat(bridge): Make session cookie timeout configurable and set default value to 60 minutes #5455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kavindu-Dodan
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5455 +/- ##
==========================================
- Coverage 54.74% 53.74% -1.01%
==========================================
Files 319 304 -15
Lines 18565 17899 -666
Branches 928 928
==========================================
- Hits 10164 9619 -545
+ Misses 7498 7405 -93
+ Partials 903 875 -28 |
Signed-off-by: Kavindu-Dodan <kavindudodanduwa@gmail.com>
Kavindu-Dodan
force-pushed
the
patch/5449/improve-oauth-session-timeout
branch
2 times, most recently
from
a1adb2c
to
6143a07
Compare
|
Thank you @Kavindu-Dodan for your contribution. Could you please fix the format of |
Signed-off-by: Kavindu-Dodan <kavindudodanduwa@gmail.com>
Kavindu-Dodan
force-pushed
the
patch/5449/improve-oauth-session-timeout
branch
from
6143a07
to
8f3e7ed
Compare
Signed-off-by: Kavindu-Dodan <kavindudodanduwa@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Kirdock
approved these changes
Oct 5, 2021
bhamail
pushed a commit
to bhamail/keptn
that referenced
this pull request
Oct 6, 2021
…t value to 60 minutes (keptn#5455) * Make session cookie configurable and set default value to 60 minutes Signed-off-by: Kavindu-Dodan <kavindudodanduwa@gmail.com> * Review update - convert env paramters to minutes to be consistant Signed-off-by: Kavindu-Dodan <kavindudodanduwa@gmail.com> * Fix lint issues Signed-off-by: Kavindu-Dodan <kavindudodanduwa@gmail.com> Signed-off-by: Dan Rollo <danrollo@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes #5449
PR improves the configurability of OAuth session cookie timeout. Further, it increases the default timeout to 60mnts in code level.
Installer argument
SESSION_TIMEOUT_MSis set in Helm template.Related Issues
#3448
How to test
If #3448 fulfilling OAuth provider is present for Bridge, this can be tested easily. Timeout can be configured by using env. variable
SESSION_TIMEOUT_MS, then validate the console output for correct value extraction and verify session timeouts in Bridge.Note - refactored method signatures in
session.tsto improve code quality.