Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

chore(shipyard-controller): Do not interpret absence of configurationChange property as an error (#5979) #5982

Merged
merged 1 commit into from Nov 12, 2021

Conversation

bacherfl
Copy link
Member

Closes #5979

Note: The problem described in #5979 that prevented the delivery sequence was caused by a misconfiguration of the remote-exec plane helm-service. However, the missing configurationChange property should not be interpreted as an error since deployment.triggered events do not have the strict requirement of having this property.

…Change property as an error (#5979)

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Nov 11, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #5982 (2ef8808) into master (d76eccc) will increase coverage by 0.51%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5982      +/-   ##
==========================================
+ Coverage   52.72%   53.24%   +0.51%     
==========================================
  Files         416      327      -89     
  Lines       24425    22278    -2147     
  Branches     1379     1058     -321     
==========================================
- Hits        12879    11861    -1018     
+ Misses      10581     9525    -1056     
+ Partials      965      892      -73     
Impacted Files Coverage Δ
shipyard-controller/common/keptn_helpers.go 24.61% <100.00%> (ø)
shipyard-controller/db/mongodb_project_mv_repo.go 61.93% <100.00%> (+0.43%) ⬆️
shipyard-controller/handler/sequence_migrator.go 69.41% <100.00%> (+0.99%) ⬆️
...-controller/handler/sequencehooks/sequencestate.go 62.45% <100.00%> (+0.85%) ⬆️
...s/ktb-sequence-view/ktb-sequence-view.component.ts 30.32% <0.00%> (-29.02%) ⬇️
bridge/client/app/_utils/form.utils.ts 63.63% <0.00%> (-27.28%) ⬇️
...ient/app/_interceptors/http-loading-interceptor.ts 81.81% <0.00%> (-18.19%) ⬇️
bridge/shared/models/trace.ts 73.33% <0.00%> (-12.39%) ⬇️
bridge/client/app/_models/trace.ts 55.66% <0.00%> (-6.49%) ⬇️
bridge/client/app/_services/data.service.ts 22.38% <0.00%> (-6.29%) ⬇️
... and 102 more

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2021

Docker Build Report

  • Pushed keptn/shipyard-controller:0.10.1-dev-PR-5982.202111111158 and keptn/shipyard-controller:0.10.1-dev-PR-5982 (Source: shipyard-controller/)

@bacherfl bacherfl marked this pull request as ready for review November 12, 2021 06:55
@bacherfl bacherfl requested a review from a team as a code owner November 12, 2021 06:55
@bacherfl bacherfl merged commit 28a9a92 into master Nov 12, 2021
@bacherfl bacherfl deleted the patch/5979/delivery branch November 12, 2021 10:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't trigger delivery in user-managed setup with helm chart
2 participants